View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002714 | unreal | ircd | public | 2005-12-08 16:31 | 2007-04-27 05:25 |
| Reporter | SciFi | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | unable to duplicate | ||
| Product Version | 3.2.3 | ||||
| Summary | 0002714: * doesn't seem to work anymore in ban blocks when badwords are used | ||||
| Description | there seems to be a problem when using badwords and ban blocks together. when i added a few badwords and tried to do a ban nick on "*Serv" it didn't work anymore. a ban only on "Serv" worked. After removing all of the badwords also "*Serv" worked again. i'm not very sure if it really is a bug, didn't have time to do really much of testing. | ||||
| 3rd party modules | |||||
|
|
ok that's weird now we enclosed all of the badwords into quotes and now it works. we removed them, it still works. now it either is because of some umlauts (äöü) or because of missing quotes and that only in some circumstances... so maybe it is hard to track :) additionally: we added "*\\*" as ban nick, so maybe there is a problem with that. |
|
|
okie, my testing suggests the following points: - adding *\* to the config file will cause weird behaviour, the config parser treats it as an escaped *. - adding *\\* to the config will cause *\* to get passed to the matcher ... so now the patten matcher thinks it is an escaped now. - adding *\\\\* to the config will cause *\\* to get passed to the matcher ... causeing the nick Test\Test to be forbidden. Why did changing the bad words make it work? I'm not sure ... either it changed the way the config parser was handling the escaping, or it changed the way that the matcher itself was being called. |
|
|
I believe they added support for C-style escapes (\x \n \" \\) to the config parser, which basically means all \ in old configs have to be doubled. I think the config might be missing documentation to this effect... I think the reason was probably because TRE didn't have \x which is something that's nice to have (like when spamfiltering based on CTCPs). |
|
|
Yeah, I had assumed that the config parser would require the \ to be escaped as \\ ... and a regex engine would also want the \ escaped, leading to \\\\ I also assumed that the more simplistic match code wouldn't require the second escaping.... What I don't get is why changing the way the bad words are defined would have changed the way the nick forbids work :/ |
|
|
Bump. Fixed? |
|
|
in my network is present badwords and ban nick and it worked! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-12-08 16:31 | SciFi | New Issue | |
| 2005-12-08 16:42 | SciFi | Note Added: 0010830 | |
| 2005-12-08 16:44 | SciFi | Note Edited: 0010830 | |
| 2005-12-08 17:12 | Nazzy | Note Added: 0010831 | |
| 2005-12-08 17:23 | SciFi | Note Edited: 0010830 | |
| 2005-12-08 22:00 | aquanight | Note Added: 0010834 | |
| 2005-12-08 22:20 | Nazzy | Note Added: 0010835 | |
| 2007-04-27 04:58 |
|
Note Added: 0013800 | |
| 2007-04-27 04:58 |
|
Status | new => feedback |
| 2007-04-27 05:22 | Bock | Note Added: 0013816 | |
| 2007-04-27 05:25 |
|
Status | feedback => closed |
| 2007-04-27 05:25 |
|
Resolution | open => unable to duplicate |
