| Anonymous | Login | Signup for a new account | 2010-09-08 14:52 CEST |
| Main | My View | View Issues | Change Log | Roadmap |
| Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | |||||||||||
| ID | Category | Severity | Reproducibility | Date Submitted | Last Update | |||||||
| 0003177 | [unreal] ircd | minor | always | 2006-12-28 14:23 | 2007-06-12 14:56 | |||||||
| Reporter | syzop | View Status | public | |||||||||
| Assigned To | ||||||||||||
| Priority | normal | Resolution | open | |||||||||
| Status | confirmed | Product Version | 3.3-alpha0 | |||||||||
| Summary | 0003177: Change add_Command's to CommandAdd's | |||||||||||
| Description |
For 3.3*, change all add_Command()'s to CommandAdd's, and actually remove add_Command() [or at least so modules cant use it anymore]. When converting to CommandAdd's, also fix/audit the flags. There are many command that should never origin from a server. STATS is a good example. In that case, "STATS" shouldn't get the M_SERVER flag, only M_USER. Do this for the rest as well.... Of course, when a command is added without M_SERVER, the if IsServer()..return 0.. check can be removed from the m_whatever function, since !IsServer() is guaranteed. |
|||||||||||
| Additional Information | ||||||||||||
| Tags | No tags attached. | |||||||||||
| 3rd party modules | ||||||||||||
| QA | Not touched yet by developer | |||||||||||
| U4: Need for upstream patch | No need for upstream InspIRCd patch | |||||||||||
| U4: Upstream notification of bug | Not decided | |||||||||||
| U4: Contributor working on this | None | |||||||||||
| Attached Files |
 CommandAdd.3177-1.patch [^] (68,249 bytes) 2007-04-26 05:39 CommandAdd.3177-2.patch [^] (68,253 bytes) 2007-04-26 05:57 |
|||||||||||
|
|
||||||||||||
 Relationships |
||||||
|
||||||
|
Notes |
|
|
(0012949) syzop (administrator) 2006-12-28 14:28 |
Consider something like M_REMOTE or M_LOCAL as well. So you can define whether remote user requests should be allowed. And so this too can be removed from m_nameoffunctions Examples of commands that should never originate from remote users are USERHOST, USERIP, PROTOCTL, etc... |
|
(0013721) aegis (reporter) 2007-04-26 05:42 edited on: 2007-04-26 05:58 |
IMPORTANT!: Please delete CommandAdd.3177-1.patch, it is broken! CommandAdd.3177-2.patch changes add_Command (and add_CommandX) to CommandAdd, adds modinfo->handle, adds M_USER|M_SERVER (where applicable), and removes del_Command blocks from `src/modules/*.c'. This patch doesn't modify anything about M_*, as Stskeeps will handle that. Run this patch from the Unreal root dir. Tested without failure. |
|
(0014341) stskeeps (reporter) 2007-06-12 14:56 |
Committed aegis' patch in 3.3-alpha0, .2436 |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2006-12-28 14:23 | syzop | New Issue | |
| 2006-12-28 14:23 | syzop | Relationship added | child of 0003049 |
| 2006-12-28 14:24 | syzop | Description Updated | |
| 2006-12-28 14:25 | syzop | Description Updated | |
| 2006-12-28 14:28 | syzop | Note Added: 0012949 | |
| 2007-04-19 04:20 | stskeeps | Status | new => acknowledged |
| 2007-04-26 05:39 | aegis | File Added: CommandAdd.3177-1.patch | |
| 2007-04-26 05:42 | aegis | Note Added: 0013721 | |
| 2007-04-26 05:44 | aegis | Note Edited: 0013721 | |
| 2007-04-26 05:44 | aegis | Note Edited: 0013721 | |
| 2007-04-26 05:44 | aegis | Note Edited: 0013721 | |
| 2007-04-26 05:57 | aegis | File Added: CommandAdd.3177-2.patch | |
| 2007-04-26 05:58 | aegis | Note Edited: 0013721 | |
| 2007-06-12 14:56 | stskeeps | Note Added: 0014341 | |
| 2007-06-12 14:56 | stskeeps | Status | acknowledged => confirmed |
| Copyright © 2000 - 2008 Mantis Group |  |
