0003960: Ping timeout count on client exit

(0016379)
Bock (reporter)
2010-09-22 19:12

We use this diff:
+ char scratch[32];
     int ping = 0;

     for (i = 0; i <= LastSlot; i++) {
@@ -700,7 +701,9 @@
                     Debug((DEBUG_DEBUG, "ssl accept handshake timeout: %s (%li-%li > %li)", cptr->sockhost,
                         currenttime, cptr->since, ping));
#endif
- exit_client(cptr, cptr, &me, "Ping timeout");
+ ircsprintf(scratch, "Ping timeout: %d seconds",
+ (int)(TStime() - cptr->lasttime));
+ exit_client(cptr, cptr, &me, scratch);
                 continue;

             }

Nice idea, I like it.

(0016416)
syzop (administrator)
2010-11-15 17:53

*test the new 'has patch' state in mantis which I added*

(0016440)
nenotopia (reporter)
2010-11-21 05:52

hmmph, this patch should really use ircsnprintf() in order to prevent buffer overflow.

(0017072)
syzop (administrator)
2012-08-17 10:49
edited on: 2012-08-17 10:53

- Show "Ping timeout: XYZ seconds" instead of just "Ping timeout".
Patch from darkex (0003960).

Added, took a while I guess ;p. Thanks!

http://hg.unrealircd.com/hg/unreal/rev/6ffa8616a5a7 [^]
EDIT: added http://hg.unrealircd.com/hg/unreal/rev/480e16958832 [^]

Issue History
Date Modified	Username	Field	Change
2010-09-21 11:51	darkex	New Issue
2010-09-21 11:51	darkex	File Added: pingcounter.diff
2010-09-22 19:12	Bock	Note Added: 0016379
2010-11-15 17:53	syzop	Note Added: 0016416
2010-11-15 17:53	syzop	Assigned To	=> syzop
2010-11-15 17:53	syzop	Status	new => has patch
2010-11-15 17:59	syzop	Assigned To	syzop =>
2010-11-21 05:52	nenotopia	Note Added: 0016440
2012-08-17 10:49	syzop	Note Added: 0017072
2012-08-17 10:49	syzop	Status	has patch => resolved
2012-08-17 10:49	syzop	Fixed in Version	=> 3.2.10-rc1
2012-08-17 10:49	syzop	Resolution	open => fixed
2012-08-17 10:49	syzop	Assigned To	=> syzop
2012-08-17 10:50	syzop	Note Edited: 0017072	View Revisions
2012-08-17 10:53	syzop	Note Edited: 0017072	View Revisions

Notes
(0016379) Bock (reporter) 2010-09-22 19:12	We use this diff: + char scratch[32]; int ping = 0; for (i = 0; i <= LastSlot; i++) { @@ -700,7 +701,9 @@ Debug((DEBUG_DEBUG, "ssl accept handshake timeout: %s (%li-%li > %li)", cptr->sockhost, currenttime, cptr->since, ping)); #endif - exit_client(cptr, cptr, &me, "Ping timeout"); + ircsprintf(scratch, "Ping timeout: %d seconds", + (int)(TStime() - cptr->lasttime)); + exit_client(cptr, cptr, &me, scratch); continue; } Nice idea, I like it.

(0016416) syzop (administrator) 2010-11-15 17:53	test the new 'has patch' state in mantis which I added

(0016440) nenotopia (reporter) 2010-11-21 05:52	hmmph, this patch should really use ircsnprintf() in order to prevent buffer overflow.

(0017072) syzop (administrator) 2012-08-17 10:49 edited on: 2012-08-17 10:53	- Show "Ping timeout: XYZ seconds" instead of just "Ping timeout". Patch from darkex (0003960). Added, took a while I guess ;p. Thanks! http://hg.unrealircd.com/hg/unreal/rev/6ffa8616a5a7 [^] EDIT: added http://hg.unrealircd.com/hg/unreal/rev/480e16958832 [^]

Relationships