View Revisions: Issue #5548

Summary 0005548: Logging format of user@host and in oper notices
Revision 2020-02-02 14:46 by syzop
Description At various places we show a nickname with user@host in a notice or logging. Eg:
sendto_snomask(SNO_FNICKCHANGE, "*** %s (%s@%s) has changed their nickname to %s"
    client->name, client->user->username, client->user->realhost, nick);
It would be better to replace it with a function that returns %s (%s@%s), like:
sendto_snomask(SNO_FNICKCHANGE, "*** %s has changed their nickname to %s"
    something(user), nick);

And then it will be configurable if the format should be "nick (user@host)", "nick (user@ip)" or "nick (user@host) [ip]" or something else. etc. <- no these are not final thoughts, but just to get the idea
eg via set::log-whatever-some-nice-name [userhost|userip|somethingelse]; <- again, not the final name :D

This so we can have a uniform way to communicate user information in logs and oper notices.
The function is not meant to be used for sending notices (or other information) to non-ircops.

Revision 2020-02-02 14:43 by syzop
Description At various places we show a nickname with user@host in a notice or logging. Eg:
sendto_snomask(SNO_FNICKCHANGE, "*** %s (%s@%s) has changed their nickname to %s"
    client->name, client->user->username, client->user->realhost, nick);
It would be better to replace it with a function that returns %s (%s@%s), like:
sendto_snomask(SNO_FNICKCHANGE, "*** %s has changed their nickname to %s"
    something(user), nick);

And then it will be configurable if the format should be "nick (user@host)", "nick (user@ip)" or "nick (user@host) [ip]" or something else. etc. <- no these are not final thoughts, but just to get the idea

This so we can have a uniform way to communicate user information in logs and oper notices.
The function is not meant to be used for sending notices (or other information) to non-ircops.