View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003979 | unreal | installing | public | 2010-12-21 05:51 | 2016-12-05 10:17 |
| Reporter | ohnobinki | Assigned To | ohnobinki | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.2.9-RC1 | ||||
| Target Version | 4.0.10 | Fixed in Version | 4.0.10 | ||
| Summary | 0003979: Minor Makefile cleanup/better parallel make support | ||||
| Description | Some Makefile rules are missing the `+' prefix and $(MAKE) isn't utilized like it should be in src/Makefile. The whole MAKEFLAGS variable in src/Makefile is useless because calling $(MAKE) $(MAKEFLAGS) from within the root Makefile causes any call to $(MAKE) to carry along all $(MAKEFLAGS), thus MAKEFLAGS can/should be cleaned from src/Makefile. | ||||
| Additional Information | This patch is being queued to be committed after 3.2.9 is done. | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| 3rd party modules | |||||
|
|
for 3.4 |
|
|
Target for 4.0.9. |
|
|
I just ran 'make -j3' on freebsd and it failed, 'make' worked. Probably because of this? Worth testing after the fix ;) |
|
|
> Some Makefile rules are missing the `+' prefix and $(MAKE) isn't utilized like it should be in src/Makefile. This was already in 4.0.x by now. (except it uses @+ instead of +@ or vice versa :D) > The whole MAKEFLAGS variable in src/Makefile is useless because calling $(MAKE) $(MAKEFLAGS) from within the root Makefile causes any call to $(MAKE) to carry along all $(MAKEFLAGS), thus MAKEFLAGS can/should be cleaned from src/Makefile. So only committed this cleanup.. |
|
|
https://github.com/unrealircd/unrealircd/commit/6f85ec14529ec04eb2cc15957081dcc55d2d25d6 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-12-21 05:51 | ohnobinki | New Issue | |
| 2010-12-21 05:51 | ohnobinki | Status | new => assigned |
| 2010-12-21 05:51 | ohnobinki | Assigned To | => ohnobinki |
| 2010-12-21 05:51 | ohnobinki | File Added: unreal-makefile-cleaner-recursive.patch | |
| 2013-01-09 10:19 | syzop | Note Added: 0017319 | |
| 2013-01-09 10:19 | syzop | Status | assigned => has patch |
| 2016-11-10 09:26 | syzop | Target Version | => 4.0.8.1 |
| 2016-11-10 09:26 | syzop | Note Added: 0019497 | |
| 2016-11-14 11:20 | syzop | Target Version | 4.0.8.1 => 4.0.9 |
| 2016-11-14 11:20 | syzop | Note Added: 0019517 | |
| 2016-12-04 16:26 | syzop | Target Version | 4.0.9 => 4.0.10 |
| 2016-12-05 10:08 | syzop | Note Added: 0019549 | |
| 2016-12-05 10:17 | syzop | Status | has patch => resolved |
| 2016-12-05 10:17 | syzop | Resolution | open => fixed |
| 2016-12-05 10:17 | syzop | Fixed in Version | => 4.0.10 |
| 2016-12-05 10:17 | syzop | Note Added: 0019550 |
