View Issue Details

IDProjectCategoryView StatusLast Update
0006195unrealinstallingpublic2023-03-17 10:47
ReporterValware Assigned Tosyzop  
PrioritynoneSeveritytrivialReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version6.0.4.2 
Fixed in Version6.0.7 
Summary0006195: Module manager doesn't work with FreeBSD systems
DescriptionReported by "rj1" in #unreal-support:

Installing modules using `./unrealircd module install third/<module>` doesn't work as expected on FreeBSD systems.
Running `gmake && gmake install` from the source directory seems to have corrected the issue indicating an error in the script in detecting the operating system, and which make commands to try.
Steps To ReproducePlease see additional information below
Additional InformationLog of what the script says when installing a module via the module manager:
irc@irc:~/unrealircd % ./unrealircd module install third/autovhost
Reading module repository list from '/home/irc/unrealircd/conf/modules.sources.list'...
Checking module repository https://modules.unrealircd.org/modules.list...
Downloading third/autovhost from https://raw.githubusercontent.com/unrealircd/unrealircd-contrib/unreal6/files/autovhost.c...
Test compiling third/autovhost...
Please use GNU Make (gmake) to build UnrealIRCd
Compiling third/autovhost...
Please use GNU Make (gmake) to build UnrealIRCd
Module third/autovhost compiled successfully
Running 'make install'...
Post-installation information for third/autovhost from the author:
---
 The module is installed, now all you need to do is add a 'loadmodule' line to your config file:
 loadmodule "third/autovhost";
 Then /rehash the IRCd.
 For usage information, refer to the module's documentation found at: https://gottem.nl/unreal/man/autovhost
---
All actions were successful.


https://0x0.st/oUL7.txt - Log of trying to start up server after a failed compile
TagsNo tags attached.
3rd party modules

Activities

syzop

2023-02-03 12:51

administrator   ~0022719

Hm, right, so it should detect "gmake" etc... like we do in ./Config for example... and then put that method in modulemanager.c

syzop

2023-03-17 10:47

administrator   ~0022763

Fixed! Thanks for the report. I know it probably has been mentioned before.. somewhere... at some point in time... but then it all just scrolls off the screen at IRC and I forget about it, so this bug report is rather useful :D

https://github.com/unrealircd/unrealircd/commit/9a08e39bcabdbd9520538e949bf5d7a650657276

commit 9a08e39bcabdbd9520538e949bf5d7a650657276 (HEAD -> unreal60_dev, origin/unreal60_dev, origin/HEAD)
Author: Bram Matthys <[email protected]>
Date: Fri Mar 17 10:44:10 2023 +0100

    Fix modulemanager not working on FreeBSD (./unrealircd module install ...)
    and other systems where 'make' was not GNU Make.
    It now uses the same detection mechanism as in ./Config, which
    should be knsometimes... own to work.
    
    Reported by Valware and rj1 in https://bugs.unrealircd.org/view.php?id=6195

Issue History

Date Modified Username Field Change
2022-11-25 01:26 Valware New Issue
2022-11-25 09:39 syzop Additional Information Updated
2023-02-03 12:51 syzop Assigned To => syzop
2023-02-03 12:51 syzop Status new => acknowledged
2023-02-03 12:51 syzop Note Added: 0022719
2023-03-17 10:47 syzop Status acknowledged => resolved
2023-03-17 10:47 syzop Resolution open => fixed
2023-03-17 10:47 syzop Fixed in Version => 6.0.7
2023-03-17 10:47 syzop Note Added: 0022763