View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001830unrealircdpublic2004-05-22 02:412005-03-02 20:47
ReporterStealth Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionreopened 
Summary0001830: SAMODE bug
DescriptionWhen an oper is HOp on a channel, s/he cannot override or samode a channel admin.
Steps To Reproduce1. You and another person need to be in a channel. (you also must be opered)
2. Make the user channel admin (+a), and yourself a HOp (+h)
3. Attempt to -a the user.
Additional Information[23:34] * Joins: Alex_D00m
[23:34] * irc.x-tab.org sets mode: +a Alex_D00m
[23:34] * pjoink sets mode: +h-o pjoink pjoink
-> samode #test -a Alex_D00m
[23:34] -irc.x-tab.org- *** You cannot deadmin Alex_D00m in #test, (s)he is a channel admin (+a).
-> mode #test -a Alex_D00m
[23:35] -irc.x-tab.org- *** You cannot deadmin Alex_D00m in #test, (s)he is a channel admin (+a).
TagsNo tags attached.
3rd party modules

Activities

Stealth

2004-05-22 14:20

reporter   ~0006373

samode is also sending oper override notices when an oper -a or -q's a user.

*** OperOverride -- pjoink ([email protected]) MODE #rpg -ao ` `
*** Global -- from irc.x-tab.org: pjoink used SAMODE #rpg (-ao ` `)

w00t

2004-05-23 19:25

reporter   ~0006391

Wait a minute:
That sent a global. Did you do that via services?

If so, what services... I dont have any such problems.

Stealth

2004-05-24 01:58

reporter   ~0006396

These are both using the samode command, no services.

The global on the second one (the oper override) is normal, but it shouldnt be sent if samode is used.

w00t

2004-05-24 21:16

reporter   ~0006403

Ok, first why did it send a global (thats weird)
second, i take it you have the can_override flag?

aquanight

2004-05-25 17:46

reporter   ~0006418

Global == GlobOps
-> Server GLOBOPS Boo
*** Global -- from aquanight: Boo
SAMODE sends a globops when an oper uses it (which is the Global -- from <blah>: someone used SAMODE ...
The override notice thing needs to go, however. SAMODE is already overriding it and already telling the opers about it.

Zell

2004-07-15 20:54

reporter   ~0007102

Upgrade your server to version 3.2.1

Tested in 3.2.1 (no oper override notice is sent)

*Now talking in #test
*Topic is Testme
*ChanServ sets mode: +o Zell
*Zell sets mode: -o Zell
-> SAMODE #test +o Zell
*** Global -- from Censored.Zell.Net: Zell used SAMODE #test (+o Zell)
*Zell sets mode: +o Zell

no override notices here...

w00t:
>Wait a minute:
>That sent a global. Did you do that via services?

unreal has always sent a global notice when SAMODE/SAJOIN/SAPART is used, since this affects all the linked servers.

codemastr

2004-07-16 16:02

reporter   ~0007111

Already fixed in 3.2.1.

Stealth

2004-07-17 01:44

reporter   ~0007118

Using SAMODE to remove channel admin still gives me problems:

* ChanServ sets mode: +ao Stealthness Stealthness
-> Server: SAMODE #RPG -ao Stealthness Stealthness
[ERROR] a Stealthness is a channel admin
[ERROR] o Stealthness is a channel admin

Zell

2004-07-19 15:51

reporter   ~0007164

depends on your access level.
SAMODE overrides more than normal... umm.. since u hafta be +A or higher to use it, then you already have access to override that. are you using version 3.2.1?

Stealth

2004-07-20 01:36

reporter   ~0007172

> depends on your access level.

I have EVERY flag, since it is my server it makes sence.

And yes this is 3.2.1, i always run the current ver (even though the bugnote was for 3.2)

Zell

2004-07-20 18:51

reporter   ~0007175

hmm.... haha youre right... this happens for me too
(using Win32 with no modules except cloak/commands and no modifications (clean install)):

<- :Censored.Zell.Net 499 Zell #Services :You're not a channel owner
<- :Censored.Zell.Net 974 Zell o :TestNick is a network service

(i tried deopping / -a a services bot)

on a regular nick (not services bot) with +ao, i get this:
<- :Censored.Zell.Net 499 Zell #Services :You're not a channel owner
<- :Censored.Zell.Net 974 Zell o :TestNick is a channel admin

my determination: [bug]
of course, if you have the netadmin flag, you can set mode -ao on the nick with either MODE or SAMODE. (both of them send a notice telling about it).

hmmmmmmmmmmmmmmmmmmmmmmmmmmm. any ideas codemastr? im stumped. (i could modify the modules, but, im not quite sure how to fix this one)

Stealth

2004-07-21 01:05

reporter   ~0007181

I believe Zell meant:

CANT MODE or SAMODE +ao users

(Unless you are +a or +q on the channel yourself; and ofcourse U:Lines CAN do these things as normal)

Zell

2004-07-21 16:08

reporter   ~0007194

well... having netadmin flag allowed me to override those modes. of course, being set channel owner (+q) allows you to set +qaohv regardless of your oper level.

the reason why youre having trouble with SAmode is because of how it works. it's like a regular MODE command, but, hides who did it by telling the users in the room that the Server did it.

->Server: SAMODE #Test +z
* Censored.Zell.Net sets mode: +z

But, it still checks your access level when you run the command. However, if you have access to SAMODE, i think you should be able to override a +ao with it... IMHO the whole point of SAMODE is for admins who normally have access to operserv stuff, so they can still function when services are down.

but, SAMODE is still rejecting the command because of how it checks your access to the normal MODE command. (only NetAdmins can set/unset modes +ao on a user in channel, while they are not +qo themselves.)

any ideas codemastr? syzop?

Stealth

2004-07-22 01:48

reporter   ~0007206

Zell, STFU already.

1. I know very well how the SAMODE works.

2. I HAVE the NetAdmin flag and ALL the other oper flags.

3. The reson this post is here, is becasue the command DOES NOT work the way it should with proper permissions.

Other than that, I would like Syzop or codemastr to look into this issue and fix it. (that seems to be why I reopened it)

Zell

2004-07-22 12:51

reporter   ~0007219

The reason i keep mentioning the NetAdmin flag is because of how samode is made... but your ranting has shed light on the real problem:
[BUG]
*NetAdmin flag on your IRCd does -NOT- give you access to do SAMODE on the things you should be able to SAMODE.
[/BUG]

that reason is because on a clean compile, with all flags in my oline, I am able to /SAMODE and /MODE to unset +ao from a user that is +ao on a channel (while I am -NOT- set +ao myself). with /MODE i get OperOverride Notice and with /SAMODE i get a global about it. codemastr and syzop will most likely produce the same results, as we are [most likely] using the same files [as when I test bugs reported here I use a clean compile downloaded from here].

And yes I agree with why you posted this LOL as you SHOULD be able to set/do anything you want with NetAdmin flags.

syzop

2005-03-02 20:47

administrator   ~0009391

This should be fixed this in CVS.
If you find any issues with latest CVS, let us know.

Issue History

Date Modified Username Field Change
2004-05-22 02:41 Stealth New Issue
2004-05-22 14:20 Stealth Note Added: 0006373
2004-05-23 19:25 w00t Note Added: 0006391
2004-05-24 01:58 Stealth Note Added: 0006396
2004-05-24 21:16 w00t Note Added: 0006403
2004-05-25 17:46 aquanight Note Added: 0006418
2004-07-15 20:54 Zell Note Added: 0007102
2004-07-16 16:02 codemastr Status new => closed
2004-07-16 16:02 codemastr Note Added: 0007111
2004-07-17 01:44 Stealth Status closed => feedback
2004-07-17 01:44 Stealth Resolution open => reopened
2004-07-17 01:44 Stealth Note Added: 0007118
2004-07-19 15:51 Zell Note Added: 0007164
2004-07-20 01:36 Stealth Note Added: 0007172
2004-07-20 18:51 Zell Note Added: 0007175
2004-07-21 01:05 Stealth Note Added: 0007181
2004-07-21 16:08 Zell Note Added: 0007194
2004-07-22 01:48 Stealth Note Added: 0007206
2004-07-22 12:51 Zell Note Added: 0007219
2005-03-02 20:47 syzop Status feedback => closed
2005-03-02 20:47 syzop Note Added: 0009391