View Issue Details

IDProjectCategoryView StatusLast Update
0003584unrealircdpublic2008-02-07 21:37
ReporterAquinasHub Assigned To 
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionwont fix 
Product Version3.2.7 
Summary0003584: Crash when 'who' command was sent by a linked server
DescriptionHello,

when I send 'who' through an linked server (i.e. IRCServices Server), UnrealIRCD crashes.
3rd party modules

Relationships

has duplicate 0003688 closed The IRCd crashes on "WHO" command. 

Activities

twizted

2008-01-19 06:59

reporter   ~0014969

Perhaps you should explain in detail what you mean

I.e do u mean if ur linked to let say irc.hello.com
you being irc.boss.com

/who * crashes, or?..

AquinasHub

2008-01-19 09:08

reporter   ~0014972

Hello,

i.e. I send 'WHO' through rootserv's raw function
/msg rootserv raw who

This will make the Service Sever send 'WHO' to the server its linked to.
Not talking about the user /who command here.

Stealth

2008-01-24 00:16

reporter   ~0014975

This is because WHO is a client command, and is not meant to be sent over links.

Your Unreal crashes because there is no need to process server2server commands for validity. You are sending an invalid command, so when Unreal tries to process it, Unreal crashes.

This is why it says all over the place to NOT use OS RAW (or equiv)

Stealth

2008-01-24 00:19

reporter   ~0014978

Such "crashes" are explained in bugs 0002807, 0001132, and 0001089

0002807 has the most information about it.

AquinasHub

2008-01-24 13:13

reporter   ~0014987

Well, guess thats a reason to not fix these "crashes"..</sarcasm>

Jobe

2008-01-24 19:54

reporter   ~0014990

Last edited: 2008-01-24 19:56

http://bugs.unrealircd.org/view.php?id=3211

As you can see this was already reported, and despite being a crash bug was rejected as "invalid"

Although from what I was once told is an easy fix too, simply to check whether the source of the WHO is a server or a client, instead of assuming it's a client and then running a check to see what channels said "client" is in (which is where it crashes)

nate

2008-01-25 00:16

reporter   ~0014993

To filter out RAW data from user-mistakes may be 'Easy' in some cases to catch stuff, but shouldn't even be necessary as the mistakes shouldn't even happen.

A user shouldn't even be using RAW for such stuff if they obviously don't know what it will do, in my opinion at least :P

So to ask for a 'Fix' on such a thing seems a tad silly?

Stealth

2008-02-07 21:37

reporter   ~0015032

This won't be fixed.

This is the exact reason why people should not play with RAW commands - it crashes the server! OS RAW was designed for developer use while developing services and reproducing servies/ircd bugs, not for your OperServ to WHO users on the network.

Issue History

Date Modified Username Field Change
2008-01-18 20:36 AquinasHub New Issue
2008-01-19 06:59 twizted Note Added: 0014969
2008-01-19 09:08 AquinasHub Note Added: 0014972
2008-01-24 00:16 Stealth Note Added: 0014975
2008-01-24 00:19 Stealth Note Added: 0014978
2008-01-24 13:13 AquinasHub Note Added: 0014987
2008-01-24 19:54 Jobe Note Added: 0014990
2008-01-24 19:55 Jobe Note Edited: 0014990
2008-01-24 19:56 Jobe Note Edited: 0014990
2008-01-25 00:16 nate Note Added: 0014993
2008-02-07 21:37 Stealth QA => Not touched yet by developer
2008-02-07 21:37 Stealth U4: Need for upstream patch => No need for upstream InspIRCd patch
2008-02-07 21:37 Stealth Status new => closed
2008-02-07 21:37 Stealth Note Added: 0015032
2008-02-07 21:37 Stealth Resolution open => wont fix
2008-05-01 14:00 Stealth Relationship added has duplicate 0003688