UnrealIRCd Bug Tracker
Mantis Bugtracker
Main | My View | View Issues | Change Log | Roadmap
  

Viewing Issue Simple Details [ Jump to Notes ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0003927 [unreal] installing tweak N/A 2010-07-14 13:03 2010-07-14 23:51
Reporter warg View Status public  
Assigned To
Priority normal Resolution open  
Status acknowledged   Product Version 3.2.9
Summary 0003927: patch to make --prefix and --bindir work, also adds --ircdname
Description This patch modifies:
    Config
    configure
    Makefile.in
    unreal.in
    ircdcron/ircdchk.in
    configure.ac
    autoconf/m4/unreal.m4

This patch enables the use of:
    --prefix=PATH
    --bindir=PATH

This patch adds:
    --ircdname=NAME

This patch removes:
    --with-dpath
    --with-spath

This patch also:
    cleans up the --help output, informs the user what the defaults are, eg:
        --with-listen=BYTES Specify the listen backlog value (default: 5)
        --with-bufferpool=NUM Specify the size of the buffer pool (default: 18)
    makes the Config script play nicely with these changes
    fixes 0003926 by warning and preventing the executable path and name from being the same as the unreal script's path and name
    allows for deep pathnames (previously this wasn't possible because BINDIR was a path to a filename and not a directory, ask binki for more info on this)
Additional Information this patch was designed on cvs for unreal3_2_fixes
Tags No tags attached.
3rd party modules
QA Not touched yet by developer
U4: Need for upstream patch No need for upstream InspIRCd patch
U4: Upstream notification of bug Not decided
U4: Contributor working on this None
Attached Files ? file icon final-warg-prefix-bindir-ircdname.patch [^] (559,561 bytes) 2010-07-14 13:48
? file icon new-warg-prefix-bindir-ircdname.patch [^] (552,933 bytes) 2010-07-14 23:51

- Relationships
related to 0003926new unreal script and binary conflict 
child of 0003915new Unreal3.2.10 TODO 

-  Notes
(0016151)
warg (reporter)
2010-07-14 13:25
edited on: 2010-07-14 13:58

 please use: final-warg-prefix-bindir-ircdname.patch


this also changes --with-disable-extendedban-stacking to --disable-extendedban-stacking. this makes more sense because we're enabling/disabling a feature, not tweaking settings for a package. technically there's a few more --with-things that should maybe a --enable-thing. *shrug* just an opinion.
(0016152)
ohnobinki (developer)
2010-07-14 14:05

 Deleted other patches as mantis provides no way to mark them as ``do not use''.
(0016153)
warg (reporter)
2010-07-14 14:06

 Thanks binkmeister
(0016155)
syzop (administrator)
2010-07-14 14:32

 You should have mentioned that:
1) You are renaming the binary to 'unrealircd', or making it the default. This is not what I want, make it 'ircd' again.
2) Not sure what you did with SSL, it's at least not mentioned. Perhaps you could either scratch it, or make more clear that the =DIR is optional and will otherwise be autodetected... something like that... basically document what it does atm.

Other than that, I'd still have to review the idea of this report itself, but I'm not against it.
(0016156)
ohnobinki (developer)
2010-07-14 14:37

 > 1) You are renaming the binary to 'unrealircd', or making it the default. This is not what I want, make it 'ircd' again.

I think that, to support the standard ``./configure && make && su -c 'make install' '' paradigm, the name of the ircd binary should be renamed. A name as generic as ``/usr/bin/ircd'' cannot be claimed by any ircd project.

Would it be enough to make a symlink from ircd -> unrealircd if the installation is a ``traditional'' instead of system install?
(0016157)
syzop (administrator)
2010-07-14 16:37

 Well, who said I would like to support the standard paradigm you describe :). In fact - and you're well aware of it - I don't, I want people to go through ./Config.

Also, it's not like you are going to run 3 different ircds at the same time if you install it like that...
(0016158)
syzop (administrator)
2010-07-14 16:45

 For consideration in 3.2.10 -- need to think careful about this. Not urgent.
(0016193)
warg (reporter)
2010-07-14 22:47

 Syzop i'll reduce this to have it only enable/use --prefix, --bindir, --ircdname and remove --dpath and --spath, and not touch anything other than necessary to change that. I was bored, and perhaps took too many LARGE steps. I specifically shouldn't have assumed that changing the ircd name is a good idea. I can just leave that up to the end-user instead.
(0016194)
warg (reporter)
2010-07-14 23:50
edited on: 2010-07-15 10:27

 NEW: new-warg-prefix-bindir-ircdname.patch
DELETE: final-warg-prefix-bindir-ircdname.patch

default --with-ircdname is ircd

default --prefix is `pwd` (classic)

default --bindir is `pwd`/bin in configure, `pwd`/src in Config (classic) if
   the default is accepted

Config, Makefile.in, unreal.in, ircdcron/ircdchk.in is changed to reflect the
   above changes

I changed Config transparently (to the end-user anyway). The 2nd and 3rd
   questions are still the same, and I simply extract the bindir/ircdname
   from the answer using sed. This is so the end-user isn't confused by an
   unexpected change.

0003926 is still fixed in the exact same way.

Note @ Syzop:

I understand you don't want the typical paradigm, and want people to use Config, but as an long-time Unreal user, I believe the option should be available. Atleast if if works right, we won't have people asking stupid questions when it breaks =). We can still strongly recommend the use of Config, or maybe only support the use of Config. I guess my point is if it exists at all, then it should atleast work properly, and to the end-users expectation.

- Issue History
Date Modified Username Field Change
2010-07-14 13:03 warg New Issue
2010-07-14 13:03 warg File Added: warg-prefix-bindir-ircdname.patch
2010-07-14 13:05 warg Issue Monitored: warg
2010-07-14 13:11 warg File Added: new-warg-prefix-bindir-ircdname.patch
2010-07-14 13:11 warg Note Added: 0016150
2010-07-14 13:25 warg File Added: yet-another-warg-prefix-bindir-ircdname.patch
2010-07-14 13:25 warg Note Added: 0016151
2010-07-14 13:25 warg Note Deleted: 0016150
2010-07-14 13:28 warg File Added: damnit-yet-another-warg-prefix-bindir-ircdname.patch
2010-07-14 13:29 warg Note Edited: 0016151
2010-07-14 13:48 warg File Added: final-warg-prefix-bindir-ircdname.patch
2010-07-14 13:49 warg Note Edited: 0016151
2010-07-14 13:55 warg Note Edited: 0016151
2010-07-14 13:58 warg Note Edited: 0016151
2010-07-14 14:04 ohnobinki File Deleted: warg-prefix-bindir-ircdname.patch
2010-07-14 14:04 ohnobinki File Deleted: yet-another-warg-prefix-bindir-ircdname.patch
2010-07-14 14:05 ohnobinki File Deleted: new-warg-prefix-bindir-ircdname.patch
2010-07-14 14:05 ohnobinki File Deleted: damnit-yet-another-warg-prefix-bindir-ircdname.patch
2010-07-14 14:05 ohnobinki Note Added: 0016152
2010-07-14 14:05 ohnobinki Issue Monitored: ohnobinki
2010-07-14 14:06 warg Note Added: 0016153
2010-07-14 14:32 syzop Note Added: 0016155
2010-07-14 14:37 ohnobinki Note Added: 0016156
2010-07-14 16:37 syzop Note Added: 0016157
2010-07-14 16:44 syzop Relationship added child of 0003915
2010-07-14 16:45 syzop Note Added: 0016158
2010-07-14 16:58 syzop Status new => acknowledged
2010-07-14 17:01 syzop Relationship added related to 0003926
2010-07-14 22:47 warg Note Added: 0016193
2010-07-14 23:50 warg Note Added: 0016194
2010-07-14 23:51 warg File Added: new-warg-prefix-bindir-ircdname.patch
2010-07-14 23:52 warg Note Edited: 0016194
2010-07-14 23:52 warg Note Edited: 0016194
2010-07-15 10:27 warg Note Edited: 0016194

Copyright © 2000 - 2008 Mantis Group
Powered by Mantis Bugtracker