View Issue Details

IDProjectCategoryView StatusLast Update
0001381unrealircdpublic2003-11-24 20:28
ReporterAngryWolf Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSSuSEOS Version8.1
Product Version3.2-beta18 
Summary0001381: Bug with PREFIX_OP and PREFIX_AQ
DescriptionI think I found a bug with PREFIX_AQ enabled on my test server (beta19). If I set myself a channel admin/owner on a channel (and remove chmode +o from my nick), I don't receive informations such as /knock attempts and some operoverride notices. But we know, it normally should happen.
Steps To Reproduce1. AngryWolf prepares channel #test

/join #test
(ChanServ gives me +oq)
/mode #test +i-o AngryWolf

2. Someone outside tries to knock the channel.

Result: AngryWolf can't see that someone knocked into channel #test.
TagsNo tags attached.
3rd party modules

Activities

syzop

2003-11-24 14:50

administrator   ~0004091

just too late! lol ;p

syzop

2003-11-24 16:15

administrator   ~0004093

actually I made an exception.. it was just in time! Now I hope my fix was right...

--- src/channel.c 21 Nov 2003 20:30:52 -0000 1.1.1.1.6.1.2.282
+++ src/channel.c 24 Nov 2003 15:28:39 -0000
@@ -3140,8 +3140,8 @@
        {
                if (key && !strcasecmp(key, "override"))
                {
- sendto_channelprefix_butone(NULL, &me, chptr, PREFIX_OP,
- ":%s NOTICE @%s :setting channel -%c due to OperOverride request from %s",
+ sendto_channelprefix_butone(NULL, &me, chptr, PREFIX_OP|PREFIX_ADMIN|PREFIX_OWNER,
+ ":%s NOTICE ~&@%s :setting channel -%c due to OperOverride request from %s",
                                me.name, chptr->chname, mchar, sptr->name);
                        sendto_serv_butone(&me, ":%s MODE %s -%c 0", me.name, chptr->chname, mchar);
                        sendto_channel_butserv(chptr, &me, ":%s MODE %s -%c", me.name, chptr->chname, mchar);
@@ -4623,12 +4623,12 @@
 #endif
                    )) {
                        if (over == 1)
- sendto_channelprefix_butone(NULL, &me, chptr, PREFIX_OP,
- ":%s NOTICE @%s :OperOverride -- %s invited him/herself into the channel.",
+ sendto_channelprefix_butone(NULL, &me, chptr, PREFIX_OP|PREFIX_ADMIN|PREFIX_OWNER,
+ ":%s NOTICE ~&@%s :OperOverride -- %s invited him/herself into the channel.",
                                  me.name, chptr->chname, sptr->name);
                        else if (over == 0)
- sendto_channelprefix_butone(NULL, &me, chptr, PREFIX_OP,
- ":%s NOTICE @%s :%s invited %s into the channel.",
+ sendto_channelprefix_butone(NULL, &me, chptr, PREFIX_OP|PREFIX_ADMIN|PREFIX_OWNER,
+ ":%s NOTICE ~&@%s :%s invited %s into the channel.",
                                  me.name, chptr->chname, sptr->name, acptr->name);

                        add_invite(acptr, chptr);
@@ -5357,8 +5357,8 @@
                return 0;
        }

- sendto_channelprefix_butone(NULL, &me, chptr, PREFIX_OP,
- ":%s NOTICE @%s :[Knock] by %s!%s@%s (%s) ",
+ sendto_channelprefix_butone(NULL, &me, chptr, PREFIX_OP|PREFIX_ADMIN|PREFIX_OWNER,
+ ":%s NOTICE ~&@%s :[Knock] by %s!%s@%s (%s) ",
            me.name, chptr->chname, sptr->name,
            sptr->user->username, GetHost(sptr),
            parv[2] ? parv[2] : "no reason specified");

Looks like it.. at least..

AngryWolf

2003-11-24 17:41

reporter   ~0004094

Yes, I thought the same solution for this bug, so I believe it must be right. Btw, sorry I didn't notice this bug before (just found it today when I was writing a documentation for user commands), sorry for reporting it too late. :-(

syzop

2003-11-24 20:28

administrator   ~0004103

No problem. I hope it's ok in beta19 now.. to be released very soon now. (tagged in cvs, beta updated).

Issue History

Date Modified Username Field Change
2003-11-24 09:33 AngryWolf New Issue
2003-11-24 14:50 syzop Note Added: 0004091
2003-11-24 16:15 syzop Note Added: 0004093
2003-11-24 17:41 AngryWolf Note Added: 0004094
2003-11-24 20:28 syzop Status new => resolved
2003-11-24 20:28 syzop Resolution open => fixed
2003-11-24 20:28 syzop Assigned To => syzop
2003-11-24 20:28 syzop Note Added: 0004103