View Issue Details

IDProjectCategoryView StatusLast Update
0002308unrealircdpublic2007-06-10 18:51
ReporterStealth Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status confirmedResolutionopen 
Summary0002308: Virus Help Channel Suggestion
DescriptionI was playing around with the virus help channel spamfilters, and I noticed that it had been done quite well.

Unfortunatly, I have noticed that with mIRC, if the channel window is closed, all the client gets is "PART Unknown command". After that, the client has no way to re-open the channel window to get the help it needs.

Because of this, I am suggesting another option for the spamfilter which will detect a PART sent from the client and respond with a JOIN. This can either be an option, such as set::spamfilter::virus-help-channel-force-rejoin, or can be hard-coded behavior of Unreal.

For those who do not understand, there is an example in Additional Info.
Additional InformationThis is currently what happens when a client attempts to part the Virus Help Channel:
-> PART #virus.help
<- PART Unknown command

This is what I want Unreal to do:
-> PART #virus.help
<- Nick JOIN #virus.help
<- irc.server.com NOTICE Nick :You have been forced to join #virus.help because it appears your client may be infected with a virus.
TagsNo tags attached.
3rd party modules

Activities

aquanight

2005-01-30 01:36

reporter   ~0008958

Erm, I can't see why it'd return unknown command... but PART should never be refused technically, partly because of GUI clients that "assume you successfully PART" like mIRC. As for force-rejoining, well it might just be easier to just let them part the channel and they can JOIN it again, if necessary, or an oper can SAJOIN them...

Stealth

2005-01-30 01:41

reporter   ~0008959

Well, the point is to get them to get help... If they were to be able to part the Virus Help Channel, they wont know what is going on and get confused. This is why I would like Unreal to reply with a JOIN, so the client re-opens the window and they can be helped. If this doesnt happen, they will disconnect, reconnect, and have it happen all over again - which IMO is a bad thing because it is not user-friendly.

medice

2005-01-30 07:10

reporter   ~0008960

imo it's user-friendly because of this very way of implementation - some users need to be forced to their "fortune"...
several clients and 1337-scripts auto-part channels not joined by the client... - this would lead to an endless-loop until the client-owner is getting the situation...

stskeeps

2007-04-27 06:25

reporter   ~0013870

Bump. Still an issue?

Stealth

2007-04-27 11:54

reporter   ~0013889

Yes, this would still be great to have

Stealth

2007-06-10 11:40

reporter   ~0014310

Last edited: 2007-06-10 11:41

It seems mIRC is somehow receiving a PART from the server... But only when I close the window. I have no clue where this is coming from. It only happens when I actually close the window, I cannot trigger it with just issuing /part

Have some /debug (pay attention to the third to last line):
 
[09:38:56] -> nobeef.x-tab.org PART #help
[09:38:56] <- :nobeef.x-tab.org 421 Test PART :Unknown command
[09:38:56] -> nobeef.x-tab.org PART #help
[09:38:56] <- :nobeef.x-tab.org 421 Test PART :Unknown command
[09:39:40] <- :[email protected] PART #help
[09:39:40] -> nobeef.x-tab.org PART #help
[09:39:40] <- :nobeef.x-tab.org 421 Test PART :Unknown command

Stealth

2007-06-10 14:11

reporter   ~0014312

I made a post in mIRC's forum bugs section, it turns out mIRC is intentionally faking a part to itself to get the window closed. The post has grabbed Khaled's attention, as well as the attention of many people active on the mIRC forums.

So it isn't us, it's them :P

Stealth

2007-06-10 16:39

reporter   ~0014314

Another small thought:

From the mIRC forum, it looks like people are too snooty to wanna agree ("if the user clicks the X, they want the window closed, so mIRC should continue spoofing a PART to itself"). So I was thinking, perhaps have Unreal send the client a notice saying they have been quarentined for <spamfilter reason>, and they must get help from that channel, and then allow them to join back.

Example debug:
-> Nick PART #Help
<- :irc.blah.org NOTICE Nick :You have been marked as quarantined for <reason>, and you must get help from #Help. If your client has closed the window for #Help, please rejoin using /join #Help

aquanight

2007-06-10 18:51

reporter   ~0014315

I personally think the ircd shouldn't have to do workarounds for client stupidness. Most of the arguments on the board for this behavior can be done better in other ways. I'd elaborate but this isn't a mIRC bugtracker :) (else I'm sure we'd not still be on issue ids less than 4000).

Though we should probably just exempt PART/JOIN from viruschan (similar to how PART can be exempted from shun), but allow only the viruschan. That way accidental KICKs don't leave a viruschanned user SOL.

Another thought: why the heck are we saying "unknown command" to users under viruschan anyway? It really should be something more like ERR_CANNOTDOCOMMAND "You can't use this command because <blah>..."

Issue History

Date Modified Username Field Change
2005-01-30 01:32 Stealth New Issue
2005-01-30 01:36 aquanight Note Added: 0008958
2005-01-30 01:41 Stealth Note Added: 0008959
2005-01-30 07:10 medice Note Added: 0008960
2007-04-27 06:25 stskeeps Note Added: 0013870
2007-04-27 06:25 stskeeps Status new => feedback
2007-04-27 11:54 Stealth Note Added: 0013889
2007-04-27 12:55 stskeeps Status feedback => confirmed
2007-06-10 11:40 Stealth Note Added: 0014310
2007-06-10 11:41 Stealth Note Edited: 0014310
2007-06-10 14:11 Stealth Note Added: 0014312
2007-06-10 16:39 Stealth Note Added: 0014314
2007-06-10 18:51 aquanight Note Added: 0014315