View Issue Details

IDProjectCategoryView StatusLast Update
0002579unrealircdpublic2013-05-20 09:48
Reporterw00t Assigned Tonenolod 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
OSAnyOS VersionAny 
Product Version3.2.3 
Summary0002579: After synch has ended, IRCd will send JOIN instead of token regardless of PROTCTL setting.
DescriptionRead topic.

I was working on services, and noted that during synch, the IRCd would use the C token, after synch however the IRCd would start using JOIN instead of C whenever a user parted/rejoined a channel - not a good thing if you're only supporting tokens.
TagsNo tags attached.
3rd party modules

Relationships

related to 0002691 resolvednenolod Some commands don't use token form in server->server 

Activities

syzop

2005-07-02 12:05

administrator   ~0010154

I (highly) suggest you to accept both, there are some other places were we ("incorrectly") only send non-tokens etc, just because we were lazy (sometimes perhaps the reverse too, I don't remember).

As the old RFC/IP/.. saying says: be liberal in what you accept, conservative in what you send.

Thanks for the report though, because such things still need to be fixed. If you find any other places with such issues, let us know :).

w00t

2005-07-03 02:28

reporter   ~0010157

Yup, KILL does the same.

I was killing a pseudoclient and wondering why on earth it wasn't coming back - turns out I was looking for TOK_KILL (.) and recieving KILL - highly irritating, was making me think my hash functions were screwed both times :P.

I am adding support for the commands where I notice there's a problem, it just gets a little irritating, not to mention that little extra b/w it uses (especially with JOIN I'd imagine :P).

Stealth

2007-05-12 12:09

reporter   ~0014099

0003328 is a duplicate of this issue, also noting NOTICE and TSCTL (after alltime req)

nenolod

2013-05-20 09:47

reporter   ~0017622

Fixed by removing TOKEN support. :P

Issue History

Date Modified Username Field Change
2005-07-01 02:56 w00t New Issue
2005-07-02 12:05 syzop Note Added: 0010154
2005-07-03 02:28 w00t Note Added: 0010157
2007-04-27 04:43 stskeeps Status new => acknowledged
2007-05-12 10:10 aquanight Relationship added related to 0002691
2007-05-12 12:09 Stealth Note Added: 0014099
2013-05-20 09:47 nenolod Note Added: 0017622
2013-05-20 09:47 nenolod Status acknowledged => resolved
2013-05-20 09:47 nenolod Resolution open => fixed
2013-05-20 09:47 nenolod Assigned To => nenolod