0002744: [patch] Using chinese-* charset will cause crashes

ID	Project	Category	View Status	Date Submitted	Last Update

0002744	unreal	ircd	public	2006-01-07 08:02	2006-01-07 09:02

Reporter	Xuefer	Assigned To	syzop
Priority	normal	Severity	minor	Reproducibility	always
Status	resolved	Resolution	fixed
Platform	gentoo	OS	linux	OS Version	x86 stable
Product Version	3.2.3
Fixed in Version	3.2.4

Summary	0002744: [patch] Using chinese-* charset will cause crashes
Description	Index: charsys.c =================================================================== RCS file: /home/cmunk/ircsystems/cvsroot/unreal/src/Attic/charsys.c,v retrieving revision 1.1.4.1 diff -u -r1.1.4.1 charsys.c --- charsys.c 13 Mar 2005 21:02:52 -0000 1.1.4.1 +++ charsys.c 7 Jan 2006 12:32:34 -0000 @@ -241,7 +241,7 @@ / void charsys_addmultibyterange(char s1, char e1, char s2, char e2) { -MBList m = MyMallocEx(sizeof(m)); +MBList *m = MyMallocEx(sizeof(m[0])); m->s1 = s1; m->e1 = e1; such problem can be easily find out with valgrind :)
Tags	No tags attached.

3rd party modules

Date Modified	Username	Field	Change
2006-01-07 08:02	Xuefer	New Issue
2006-01-07 09:01	syzop	Summary	[patch] charsys_addmultibyterange heap overflow => [patch] Using chinese-* charset will cause crashes
2006-01-07 09:02	syzop	Status	new => resolved
2006-01-07 09:02	syzop	Fixed in Version	=> 3.2.4
2006-01-07 09:02	syzop	Resolution	open => fixed
2006-01-07 09:02	syzop	Assigned To	=> syzop
2006-01-07 09:02	syzop	Note Added: 0010947

syzop 2006-01-07 09:02 administrator ~0010947	I do use valgrind, actually, but I guess I didn't run it on the chinese nick code ;). Thanks for both the report & fix, is now fixed in CVS [.407].