View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003328 | unreal | ircd | public | 2007-05-10 17:02 | 2013-05-20 09:46 |
| Reporter | IronLegend | Assigned To | |||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | i386 | OS | Win32 | OS Version | XP |
| Product Version | 3.2.7 | ||||
| Summary | 0003328: Possible tokenization in the Server 2 Server protocol ( JOIN, NOTICE ) | ||||
| Description | A copple commands are never (in my experience) send as tokens. JOIN NOTICE there can be a cople more didnt test them all. | ||||
| Steps To Reproduce | server setup: (listen server) -> (hub) <- (sending server) hop a cople of times on a channel where a client of the listen server is in. you will see something like this: :IronLegend D #swened :IronLegend JOIN #swened :IronLegend D #swened :IronLegend JOIN #swened | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | none | ||||
| related to | 0002691 | resolved | Some commands don't use token form in server->server |
|
|
JOIN is supposed to be sending token C NOTICE is supposed to be sending token B |
|
|
so non tokens are send: on join (for a server(*) 2 hops away) -> (listen serv) -> (hub) <- (sending serv(*)) on notice send by a server and i found the tsctl command also non tokensized when all alltime is requested |
|
|
fwiw, TKL is rarely tokenized either. Not that 3 chars vs 2 chars many ppl care. Otoh, if you want simplified dispatch routines, the whole "1 char commands can be hashed" is really nice. No hash function, just setup an array of 256 function pointers, indexed off the ASCII value of the token. |
|
|
We 'fixed' this by removing the token stuff. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-05-10 17:02 | IronLegend | New Issue | |
| 2007-05-10 17:02 | IronLegend | 3rd party modules | => none |
| 2007-05-11 23:55 | Stealth | Note Added: 0014093 | |
| 2007-05-12 09:28 |
|
Status | new => acknowledged |
| 2007-05-12 09:34 | IronLegend | Note Added: 0014095 | |
| 2007-05-12 10:07 | aquanight | Relationship added | related to 0002691 |
| 2007-06-10 11:31 | tabrisnet | Note Added: 0014306 | |
| 2013-05-20 09:46 |
|
Note Added: 0017620 | |
| 2013-05-20 09:46 |
|
Status | acknowledged => resolved |
| 2013-05-20 09:46 |
|
Resolution | open => fixed |
| 2013-05-20 09:46 |
|
Assigned To | => nenolod |
