View Issue Details

IDProjectCategoryView StatusLast Update
0003973unrealircdpublic2018-09-07 12:08
ReporterMr_SmokeAssigned Tosyzop 
PrioritynormalSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
Product Version 
Target Version4.2.0Fixed in Version4.2.0 
Summary0003973: Log linking attempts
DescriptionSo far, Unreal only logs server connects and disconnects. It might be
interesting to also log linking attempts and why they fail, so as to help
investigating the issue at hand.
TagsNo tags attached.
3rd party modules

Activities

katsklaw

2010-12-10 22:41

reporter   ~0016452

\o second

syzop

2010-12-29 18:30

administrator   ~0016534

agreed

Mr_Smoke

2018-05-04 11:15

reporter   ~0020128

This one has been in the backlog for a while now :) Any news? Issue 0003972 has reared its ugly head again, this might help…

syzop

2018-06-23 08:38

administrator   ~0020180

Target for 4.0.19.

syzop

2018-09-07 11:02

administrator   ~0020285

Last edited: 2018-09-07 11:03

View 3 revisions

Updating verify_link() is easy. That would deal with logging verification errors for incoming links such as 'no link block named xx', 'Authentication failed' and that sort of stuff.
But code for outgoing and network errors is all over the place. Would need more work.

Also, should this be a new logging category? I'm not sure.
I'm thinking incoming link verification errors should always be logged. They are major (security-wise) and it's strange they are not logged at all right now. They should be in the 'error' class.
Outgoing link attempts (and errors)... perhaps a new category? Or log them to errors as well... It's unusual for this not to be significant after all.

syzop

2018-09-07 12:01

administrator   ~0020286

Thanks for the suggestion. Should now work.

commit ab321f632b0b240076838ccf0b57a8ad35aa6441 (HEAD -> unreal40, origin/unreal40, origin/HEAD)
Author: Bram Matthys <syzop@vulnscan.org>
Date: Fri Sep 7 11:59:52 2018 +0200

    For outgoing server connection attempts there was no message to ircops
    nor to the log about connection or handshake timeouts. Now there is.

commit bd19e9c87a42b01d43d0fea1eff62acb9b0dd69a
Author: Bram Matthys <syzop@vulnscan.org>
Date: Fri Sep 7 11:57:47 2018 +0200

    Log linking attempts and errors. Also report them to IRCOps in an uniform way.
    Reported by Mr_Smoke in https://bugs.unrealircd.org/view.php?id=3973

syzop

2018-09-07 12:08

administrator   ~0020287

commit 9ed6a9ae79539b7eff4715113f66007fe16a3510 (HEAD -> unreal40, origin/unreal40, origin/HEAD)
Author: Bram Matthys <syzop@vulnscan.org>
Date: Fri Sep 7 12:07:09 2018 +0200

    Found some more for 0003973


**

I tested the following cases:
* Connect timeout (iptables DROP)
* Connection refused (iptables REJECT)
* Disconnect an established connection

Naturally there are more possibilities, but those were the ones I could quickly test :)

Issue History

Date Modified Username Field Change
2010-12-10 20:56 syzop New Issue
2010-12-10 20:57 syzop Reporter syzop => Mr_Smoke
2010-12-10 22:41 katsklaw Note Added: 0016452
2010-12-29 18:30 syzop Note Added: 0016534
2010-12-29 18:30 syzop Status new => confirmed
2018-05-04 11:15 Mr_Smoke Note Added: 0020128
2018-06-23 08:38 syzop Target Version => 4.2.0
2018-06-23 08:38 syzop Note Added: 0020180
2018-07-14 16:35 syzop Sticky Issue No => Yes
2018-09-07 11:02 syzop Note Added: 0020285
2018-09-07 11:03 syzop Note Edited: 0020285 View Revisions
2018-09-07 11:03 syzop Note Edited: 0020285 View Revisions
2018-09-07 12:01 syzop Assigned To => syzop
2018-09-07 12:01 syzop Status confirmed => resolved
2018-09-07 12:01 syzop Resolution open => fixed
2018-09-07 12:01 syzop Fixed in Version => 4.2.0
2018-09-07 12:01 syzop Note Added: 0020286
2018-09-07 12:08 syzop Note Added: 0020287