View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004075 | unreal | ircd | public | 2012-01-17 20:01 | 2018-12-12 09:24 |
| Reporter | bekarfel | Assigned To | syzop | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | x64 | OS | Windows Vista Ultimate | OS Version | SP2 (6.0.6002) |
| Product Version | 3.2.9 | ||||
| Fixed in Version | 4.2.1 | ||||
| Summary | 0004075: comments within comments are not ignored | ||||
| Description | having a /*comment within a /* comment will cause the IRCd to complain with [error] D:\program files\unreal3.2\common.ircd.conf:37 Comment on this line does not end [error] Could not load config file D:\program files\unreal3.2\common.ircd.conf [error] IRCd configuration failed to load if the both */ comments aren't closed | ||||
| Steps To Reproduce | [37] /* the following are commented out until we can get updates! [38] loadmodule "modules/cmdflood.dll"; [39] loadmodule "modules/identonly.dll"; [40] loadmodule "modules/m_nochan.dll"; [41] loadmodule "modules/m_privdeaf.dll"; [42] loadmodule "modules/m_regexcept.dll"; [43] loadmodule "modules/m_securequery.dll"; [44] /* The following modules are commented out until we can get information on how they work [45] */ | ||||
| Additional Information | a /* comment within a /* comment should be ignored until a close comment */ is received? | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Agreed. Very annoying. I've experienced this myself (eg, when I talk about /*LINE in a comment). |
|
|
So then you are asking for comments to not really be comments? Then suddenly `/*' would have special meaning within a comment instead of just being ignored. |
|
|
Right now it's like you describe, binki, which is bad. So if you have two /*'s then you also need two */'s to end the comment(s). What I want, is it to behave like any other normal (C) parser. So in a comment, additional /*'s are ignored, and the first occurrence of a */ ends the comment. |
|
|
Ah, I approve then :-) |
|
|
I believe Atheme's config parser (which is basically the same as the one in Unreal; same origin anyway) already has fixed this bug, if so I will make a patch to port it over. |
|
|
bump |
|
|
https://github.com/unrealircd/unrealircd/commit/51ed51dff1177c0dd860145117167353ac1b89fb commit 51ed51dff1177c0dd860145117167353ac1b89fb Author: Bram Matthys <[email protected]> Date: Sat Dec 8 15:51:50 2018 +0100 Remove non-standard 'nested comments' features, also known as "comments within comments are not ignored". Reported by bekarfel in https://bugs.unrealircd.org/view.php?id=4075 FAQ entry: https://www.unrealircd.org/docs/FAQ#Nesting_comments |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-01-17 20:01 | bekarfel | New Issue | |
| 2012-01-18 11:12 | syzop | Note Added: 0016868 | |
| 2012-01-18 11:12 | syzop | Status | new => confirmed |
| 2012-01-18 22:11 | ohnobinki | Note Added: 0016869 | |
| 2012-01-19 10:15 | syzop | Note Added: 0016871 | |
| 2012-01-19 17:39 | ohnobinki | Note Added: 0016872 | |
| 2012-01-22 10:04 |
|
Note Added: 0016879 | |
| 2015-08-08 08:37 | syzop | Note Added: 0018577 | |
| 2018-12-12 09:24 | syzop | Assigned To | => syzop |
| 2018-12-12 09:24 | syzop | Status | confirmed => resolved |
| 2018-12-12 09:24 | syzop | Resolution | open => fixed |
| 2018-12-12 09:24 | syzop | Fixed in Version | => 4.2.1 |
| 2018-12-12 09:24 | syzop | Note Added: 0020405 |
