View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004184 | unreal | ircd | public | 2013-04-08 15:25 | 2013-05-06 02:02 |
| Reporter | grawity | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.2.10 | ||||
| Fixed in Version | 3.4-alpha1 | ||||
| Summary | 0004184: STARTTLS – sends an empty parameter instead of * during registration | ||||
| Description | When STARTTLS is used during registration before NICK is sent, the reply (RPL_STARTTLS) will have an empty parameter in place of the nick: <<< :radian.cluenet.org CAP * LS :account-notify away-notify multi-prefix sasl tls userhost-in-names >>> STARTTLS <<< :radian.cluenet.org 670 :STARTTLS successful, go ahead with TLS handshake This should probably look like: <<< :radian.cluenet.org 670 * :STARTTLS successful, go ahead with TLS handshake | ||||
| Steps To Reproduce | 1. Connect to the server 2. Send "STARTTLS\n" 3. Read reply | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| 3rd party modules | |||||
|
|
Attahced patch (starttls.patch) to fix numerics 670 (RPL_STARTTLS) and 691 (ERR_STARTTLS) to use * instead of an empty sptr->name pointer. |
|
|
I don't like that patch as it breaks RFC1459 convention. We should only send * when we do not know the client name. I am committing a different patch that does this instead. |
|
|
http://hg.unrealircd.org/hg/unreal/rev/ceb4291fd315 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-04-08 15:25 | grawity | New Issue | |
| 2013-04-08 18:25 | syzop | Status | new => acknowledged |
| 2013-04-09 02:24 | Stealth | File Added: starttls.patch | |
| 2013-04-09 02:25 | Stealth | Note Added: 0017473 | |
| 2013-04-14 10:39 | syzop | Status | acknowledged => has patch |
| 2013-05-06 01:58 |
|
Note Added: 0017480 | |
| 2013-05-06 02:02 |
|
Note Added: 0017481 | |
| 2013-05-06 02:02 |
|
Status | has patch => resolved |
| 2013-05-06 02:02 |
|
Fixed in Version | => 3.4-alpha1 |
| 2013-05-06 02:02 |
|
Resolution | open => fixed |
| 2013-05-06 02:02 |
|
Assigned To | => nenolod |
