View Issue Details

IDProjectCategoryView StatusLast Update
0004976unrealircdpublic2019-10-14 14:55
ReporterGottemAssigned Tosyzop 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.0.12.1 
Target VersionFixed in Version5.0.0-alpha3 
Summary0004976: Clarify output of tkl update
DescriptionRight now, when you update an existing TKLine, opers get a notice like:

tkl update for nick@host/reason='test2'/by=opernick!ident@host/set=1501365256/expire=1501366228 [causedby: hub.my.net]

But most of it is not relevant/human readable. =]

Points to improve:
* 'by' field shows the oper (or server) who originally set the TKLine, not who _changed_ it
* 'set' could either be omitted or changed to read like 'Sat Jul 29 21:54:16 2017 GMT'
* 'expire' should also read like 'Sat Jul 29 22:10:28 2017 GMT'
* 'causedby' could be omitted as well, as it's not really correct information (it always shows the server to which the oper is connected, even though the oper himself changed it)

So perhaps something like:
*** [Permanent] <X:Line|Shun> updated for nick@host by <opernick!ident@host|servername> (to expire at Sat Jul 29 22:10:28 2017 GMT: test2)

And:
*** [Permanent] <X:Line|Shun> updated for nick@host by <opernick!ident@host|servername> (to never expire: test2)

So you know, a format similar to adding/removing/expiring TKLines. :>
Steps To ReproduceFirst, as oper1: /gline someone@somehost 600 test

Second, as oper2: /gline someone@somehost 900 test2

Then check the server console output
TagsNo tags attached.
3rd party modulesN/A

Activities

syzop

2017-11-01 10:26

administrator   ~0019941

That's true. I added the 'tkl update' code to trace some mysterious updates looong ago and did so in a debug-like matter :)

syzop

2019-10-14 14:55

administrator   ~0020963

More or less fixed by simply not showing the update anymore :D

Issue History

Date Modified Username Field Change
2017-07-30 16:07 Gottem New Issue
2017-07-30 21:10 Gottem Tag Attached: test
2017-07-30 21:10 Gottem Tag Detached: test
2017-11-01 10:26 syzop Status new => confirmed
2017-11-01 10:26 syzop Note Added: 0019941
2019-10-14 14:55 syzop Assigned To => syzop
2019-10-14 14:55 syzop Status confirmed => resolved
2019-10-14 14:55 syzop Resolution open => fixed
2019-10-14 14:55 syzop Fixed in Version => 5.0.0-alpha3
2019-10-14 14:55 syzop Note Added: 0020963