View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0005066||unreal||ircd||public||2018-02-05 01:29||2018-04-22 09:45|
|Platform||Unix||OS||Ubuntu||OS Version||16.04 LTS|
|Target Version||Fixed in Version||4.0.18|
|Summary||0005066: Numeric conflict (?) in m_ircops|
|Description||This issue arised when an instance of a webchat system known as TheLounge (https://github.com/thelounge/lounge) and using the irc-framework from here https://github.com/kiwiirc/irc-framework crashed when issuing the /ircops command.|
I've researched a bit and in m_icops.c we have the following lines:
#define RPL_IRCOPS 337
#define RPL_ENDOFIRCOPS 338
but in numeric.h we have:
#define RPL_ENDOFINVITELIST 337
Seems the idea of choosing the numerics on m_ircops was to: "Ultimate uses numerics 386 and 387 for RPL_IRCOPS and RPL_ENDOFIRCOPS, but these numerics are RPL_QLIST and RPL_ENDOFQLIST in UnrealIRCd (numeric conflict). I had to choose other numerics."
Still, we have the RPL_IRCOPS conflicting with a already existent numeric in UnrealIRCd.
I've digged a bit more, and seems that 338 and 339 are available, so to get rid of the conflict (at least inside the IRCd itself), we could set the numerics to:
#define RPL_IRCOPS 338
#define RPL_ENDOFIRCOPS 339
If valuable for anything, the stacktrace of TheLounge crash is availabe here: https://paste.ubuntu.com/26515341/ and the issue discussion was been started here: https://github.com/kiwiirc/irc-framework/issues/137
|3rd party modules|
Numeric conflict resolved, thanks for the report :)
Author: Bram Matthys <email@example.com>
Date: Sun Apr 22 09:42:14 2018 +0200
Make m_ircops use RPL_TEXT rather than conflicting numeric.
The output of /IRCOPS isn't meant to be client parsable anyway (which
can be seen by the use of bold text and such), so using a generic
numeric rather than wasting two others seems sensible.
Reported by The_Myth in 0005066.
|2018-02-05 01:29||The_Myth||New Issue|
|2018-02-05 01:29||The_Myth||Tag Attached: Module|
|2018-04-22 09:45||syzop||Assigned To||=> syzop|
|2018-04-22 09:45||syzop||Status||new => resolved|
|2018-04-22 09:45||syzop||Resolution||open => fixed|
|2018-04-22 09:45||syzop||Fixed in Version||=> 4.0.18|
|2018-04-22 09:45||syzop||Note Added: 0020104|