View Issue Details

IDProjectCategoryView StatusLast Update
0005501unrealircdpublic2020-01-02 15:48
ReporterwestorAssigned Tosyzop 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version5.0.0 
Target VersionFixed in Version5.0.1 
Summary0005501: Blacklist module doesn't allow clients to connect if warn action set
DescriptionHello,

I noticed that when i set in unrealircd.conf into a blacklist block a warn action , then when the client is trying to connect, the warn action is acting like action kill upon the client
but it sending the server notice.

Example:

[Blacklist] IP 94.66.223.208 matches blacklist justspamrbl (dnsbl.justspam.org/reply=2)

Config:

blacklist justspamrbl {
        dns {
                name dnsbl.justspam.org;
                type record;
                reply { 2; };
        };
        action warn;
        ban-time 1h;
        reason "Possible IRC Proxy/Drone/TOR detected via JustSpam RBL service, Check http://justspam.org/check/?ip=$ip for details, if this action was incorrect then email us on abuse@mirc.gr including that message.";
};

User report:

Closing Link: [94.66.223.208] (Possible IRC Proxy/Drone/TOR detected via JustSpam RBL service, Check http://justspam.org/check/?ip=94.66.223.208 for details, if this action was incorrect then email us on abuse@mirc.gr including that message.)
TagsNo tags attached.
3rd party modules

Relationships

related to 0005276 resolvedsyzop UnrealIRCD blacklist + antirandom modules doesn't let the user connect in if ban-action is warn,shun,tempshun,kill 

Activities

syzop

2020-01-02 15:48

administrator   ~0021189

This bug uncovered some other bugs as well. Thanks for the report, fixed for 5.0.1:

commit d7d673faf2e38eeac915d369c7748686fdb23af2
Author: Bram Matthys <syzop@vulnscan.org>
Date: Thu Jan 2 14:25:28 2020 +0100

    Multiple fixes related to ban actions:
    1) Fix issue if HOOKTYPE_IS_HANDSHAKE_FINISHED rejects the user
    2) Fix authprompt issue. We now allow adding the TKL in
       place_ban_host() for soft-kline/etc. Previously all the
       soft-kline/gline/zline/gzline acted like soft-kill.
    3) The blacklist module did not allow clients in with action 'warn',
       reported by westor in https://bugs.unrealircd.org/view.php?id=5501

Issue History

Date Modified Username Field Change
2019-12-18 21:44 westor New Issue
2019-12-30 17:45 syzop Relationship added related to 0005276
2020-01-02 13:22 syzop Assigned To => syzop
2020-01-02 13:22 syzop Status new => assigned
2020-01-02 13:22 syzop Priority urgent => normal
2020-01-02 15:48 syzop Status assigned => resolved
2020-01-02 15:48 syzop Resolution open => fixed
2020-01-02 15:48 syzop Fixed in Version => 5.0.1
2020-01-02 15:48 syzop Note Added: 0021189