View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005657 | unreal | documentation | public | 2020-04-29 10:28 | 2020-04-29 16:33 |
| Reporter | patphobos | Assigned To | syzop | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | Ubuntu | OS Version | 20.04 |
| Product Version | 5.0.4 | ||||
| Fixed in Version | 5.0.5 | ||||
| Summary | 0005657: who are limited to 100 results, when configured without limit (module whox.c) | ||||
| Description | when unconfigued who-limit value is set to 0, the server only return 100 results. the documentation https://www.unrealircd.org/docs/Set_block says : set::who-limit ; Syntax: set::who-limit <limit> ; Sets the limit for the maximum number of matches that will be returned for a /who. If this option is left out, no limit is enforced. but the source code of whox.c contradict this statement : static void who_global(Client *client, char *mask, int operspy, struct who_format *fmt) { Client *acptr; int maxmatches = WHOLIMIT ? WHOLIMIT : 100; | ||||
| Steps To Reproduce | no who-limit configuration /who * with more than 100 connected users | ||||
| Additional Information | fix the documentation ? default who-limit value to 100 when unconfigured ? what value to use in order to obtain a /who without limit ? | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | whox | ||||
|
|
Thanks for the report. I have updated the documentation at https://www.unrealircd.org/docs/Set_block#set::who-limit As for your question how high to set for unlimited, well you can set it to 1 million that should be sufficiently high I think :D Also I only just now noticed that the limit also applies to IRCOps, which is not what we want, so IRCOps are exempt now, which is what this commit is for: commit aba3c8e53fe700f70bbb85dd47e807a257adfff6 (HEAD -> unreal50) Author: Bram Matthys <[email protected]> Date: Wed Apr 29 16:27:46 2020 +0200 Fix set::who-limit documentation and make IRCOps exempt from this limit. reported by patphobos in https://bugs.unrealircd.org/view.php?id=5657 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-04-29 10:28 | patphobos | New Issue | |
| 2020-04-29 16:33 | syzop | Assigned To | => syzop |
| 2020-04-29 16:33 | syzop | Status | new => resolved |
| 2020-04-29 16:33 | syzop | Resolution | open => fixed |
| 2020-04-29 16:33 | syzop | Fixed in Version | => 5.0.5 |
| 2020-04-29 16:33 | syzop | Note Added: 0021537 |
