View Issue Details

IDProjectCategoryView StatusLast Update
0005753unrealircdpublic2020-09-26 12:18
ReporterApocalypse32 Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version5.0.6 
Fixed in Version5.0.7-rc1 
Summary0005753: /links will show in mIRC even when disabled.
Description-
[08:15:55] -*- *** Disabled for security reasons
-
[08:15:55] Retrieving links...
[08:15:55] End of /LINKS list.
-

When disabled it still will retrieve the links and mIRC will get it.
Steps To Reproduce/links
TagsNo tags attached.
3rd party modules

Activities

Lord255

2020-09-18 20:45

reporter   ~0021744

are you using the hideserver block? did you write the affected servers there?
how many servers are visible in the window?
are you trying this with a regular user? (means non-oper)

Apocalypse32

2020-09-20 15:32

reporter   ~0021746

yes its using the hideserver block.
i writed the affected server yes, anybody who uses:

 hideserver {
        disable-map yes;
        disable-links yes;
        map-deny-message "*** Disabled for security reasons";
        links-deny-message "*** Disabled for security reasons";

};

tryed it with regular user on severeal servers that i don't own and it just shows all the links.
links2.png (63,855 bytes)
serverlinks1.png (87,177 bytes)

syzop

2020-09-26 12:18

administrator   ~0021752

Thanks for the report, was indeed something silly, fixed now.

https://github.com/unrealircd/unrealircd/commit/02f0d059c54df3ed26aefbd61b6d6f37a7fcc5ff

commit 02f0d059c54df3ed26aefbd61b6d6f37a7fcc5ff (HEAD -> unreal50)
Author: Bram Matthys <[email protected]>
Date: Sat Sep 26 12:16:17 2020 +0200

    hideserver::disable-links did did not disable /LINKS.
    Reported by Apocalypse32 in https://bugs.unrealircd.org/view.php?id=5753
    Probably since 5.0.0, due to my mass command api changes.

Issue History

Date Modified Username Field Change
2020-09-13 08:19 Apocalypse32 New Issue
2020-09-18 20:45 Lord255 Note Added: 0021744
2020-09-20 15:32 Apocalypse32 Note Added: 0021746
2020-09-20 15:32 Apocalypse32 File Added: links2.png
2020-09-20 15:32 Apocalypse32 File Added: serverlinks1.png
2020-09-26 12:18 syzop Assigned To => syzop
2020-09-26 12:18 syzop Status new => resolved
2020-09-26 12:18 syzop Resolution open => fixed
2020-09-26 12:18 syzop Fixed in Version => 5.0.7-rc1
2020-09-26 12:18 syzop Note Added: 0021752