View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006105 | unreal | ircd | public | 2022-05-18 22:48 | 2024-10-18 12:23 |
| Reporter | PeGaSuS | Assigned To | syzop | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | Ubuntu | OS Version | 20.04 |
| Product Version | 6.0.3 | ||||
| Fixed in Version | 6.1.8.1 | ||||
| Summary | 0006105: GLINE always assume 2nd argument as reason, if no reason is specified. | ||||
| Description | Example:/gline *@123.123.123.123 12h is converted into G-Line added: '*@123.123.123' [reason: 12h] [by: James!WeeChat@PTirc/Staff/James] [duration: permanent] Opening this bug due to: <@DALEK> not sure if bug <@DALEK> [16:38:05] -irc.valware.uk- [info] G-Line added: '*@test' [reason: +12h] [by: [email protected]] [duration: permanent] <@DALEK> permanent with reason +12h lol <@westor> DALEK: what you typed? <@DALEK> /gline nick +12h Cheers! | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Going by helpop, it should be noted that for /GLINE, "time" is optional and "reason" is not: Syntax: GLINE <user@host mask or nick> [time] <reason> |
|
|
Adding some thoughts to this: - If 2nd arg is an integer, assume duration with default reason - If 2nd arg isn't an integer assume reason with permanent duration |
|
|
Fixed by Valware via PR https://github.com/unrealircd/unrealircd/pull/304 Commit https://github.com/unrealircd/unrealircd/commit/8e47aff2cf7ca3e1b30d5169b6f11c17f4c5a37b commit 8e47aff2cf7ca3e1b30d5169b6f11c17f4c5a37b (HEAD -> unreal60_dev, origin/unreal60_dev, origin/HEAD) Author: Valerie Liu <[email protected]> Date: Wed Oct 16 16:01:12 2024 +0800 Make *LINE behave smarter if missing reason or time value (#304) Now this works like: if the time param exists, even without a reason, it will be checked if it's a time param. if it's not a time param, it'll be considered to be the reason (or the first part of it anyway) Reported by PeGaSuS in https://bugs.unrealircd.org/view.php?id=6105 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-05-18 22:48 | PeGaSuS | New Issue | |
| 2022-05-19 01:16 | Jobe | Note Added: 0022488 | |
| 2023-03-21 13:55 | PeGaSuS | Note Added: 0022801 | |
| 2024-10-16 10:02 | syzop | Assigned To | => syzop |
| 2024-10-16 10:02 | syzop | Status | new => resolved |
| 2024-10-16 10:02 | syzop | Resolution | open => fixed |
| 2024-10-16 10:02 | syzop | Fixed in Version | => 6.1.8 |
| 2024-10-16 10:02 | syzop | Note Added: 0023388 | |
| 2024-10-18 12:23 | syzop | Fixed in Version | 6.1.8 => 6.1.8.1 |
