View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006166 | unreal | ircd | public | 2022-08-22 13:08 | 2022-12-07 08:19 |
| Reporter | adamus1red | Assigned To | syzop | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 6.0.4 | ||||
| Fixed in Version | 6.0.5-rc1 | ||||
| Summary | 0006166: Chathistory fails when target is a nickname | ||||
| Description | When requesting a chathistory with the BEFORE subcommand on a nickname unrealircd returns a INVALID_TARGET failure message. | ||||
| Steps To Reproduce | Using gamja connect to a websocket port. Open a new chat or recieve a new chat message. gamja will request chathistory. failure message generated. | ||||
| Additional Information | Reported to gamja developers who indicated it was a server issue. https://todo.sr.ht/~emersion/gamja/145 Raw Log: CAP REQ :account-notify away-notify batch chghost echo-message extended-join invite-notify labeled-response message-tags multi-prefix sasl server-time setname draft/chathistory draft/extended-monitor :irc.lan CAP terst ACK :account-notify away-notify batch chghost echo-message extended-join invite-notify labeled-response message-tags multi-prefix sasl server-time setname draft/chathistory draft/extended-monitor <MOTD, etc> <Get message from adamus1red> MONITOR + adamus1red @label=2 WHO adamus1red %tfhnrua,0 @label=3 CHATHISTORY BEFORE adamus1red timestamp=2022-08-22T10:45:01.632Z 50 :irc.lan 730 terst :[email protected] @label=2 :irc.lan BATCH +QrRa85QmK7yw4QMO9cbOg5 labeled-response @batch=QrRa85QmK7yw4QMO9cbOg5 :irc.lan 354 terst 0 ~M this.is.my.vhost adamus1red Hrs* adamus1red :Mario @batch=QrRa85QmK7yw4QMO9cbOg5 :irc.lan 315 terst adamus1red :End of /WHO list. :irc.lan BATCH -QrRa85QmK7yw4QMO9cbOg5 @label=3 :irc.lan FAIL CHATHISTORY INVALID_TARGET BEFORE adamus1red :Messages could not be retrieved, not an existing channel | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
I suppose it is a similar situation to https://github.com/ircv3/ircv3-specifications/issues/437#issuecomment-981057377 (when a channel is not +H) We could change it in UnrealIRCd to do the same as that case, send an empty batch. |
|
|
Thanks for the report, this is now done in https://github.com/unrealircd/unrealircd/commit/7bab7144ed630343759e898aa467dbb1fbc4bfd9 This will be in UnrealIRCd 6.0.5 (-rc1 too). |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-08-22 13:08 | adamus1red | New Issue | |
| 2022-08-29 08:56 | syzop | Note Added: 0022626 | |
| 2022-12-07 08:19 | syzop | Assigned To | => syzop |
| 2022-12-07 08:19 | syzop | Status | new => resolved |
| 2022-12-07 08:19 | syzop | Resolution | open => fixed |
| 2022-12-07 08:19 | syzop | Fixed in Version | => 6.0.5-rc1 |
| 2022-12-07 08:19 | syzop | Note Added: 0022676 |
