View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0006350unrealircdpublic2023-10-12 10:002023-10-12 18:48
ReporterBlackBishop Assigned Tosyzop  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version6.1.2.2 
Fixed in Version6.1.2.3 
Summary0006350: exclude-security-group not working?
DescriptionI want to give oldtimers ( 10k rep users ) various privileges.
I also have an SG for irccloudv4 users which shouldn't get that privilege since their IP is the same.
Steps To ReproduceCreate SG
security-group oldtimers {
  reputation-score 10000;
};
Notice irccloud users on v4 having the oldtimers SG. So create an SG for them
security-group irccloudv4 {
  ip {
    5.254.36.56/29;
    5.254.36.104/29;
  };
};
And add it do the initial oldtimers SG as an exclude
security-group oldtimers {
  reputation-score 10000;
  exclude-security-group {
    irccloudv4;
  };
};
Rehash.
Now the users have oldtimers and irccloudv4
TagsNo tags attached.
3rd party modules

Activities

syzop

2023-10-12 18:48

administrator   ~0023057

Didn't test but pretty sure this is it ;D

https://github.com/unrealircd/unrealircd/commit/b085da458a15a663443f8241ccca3e7e43ac9580

commit b085da458a15a663443f8241ccca3e7e43ac9580 (HEAD -> unreal60_dev, origin/unreal60_dev, origin/HEAD)
Author: Bram Matthys <[email protected]>
Date: Thu Oct 12 18:46:18 2023 +0200

    Fix ::exclude-security-group not working.
    Reported by BlackBishop in https://bugs.unrealircd.org/view.php?id=6350

diff --git a/src/securitygroup.c b/src/securitygroup.c
index a41456820..457df09ab 100644
--- a/src/securitygroup.c
+++ b/src/securitygroup.c
@@ -456,7 +456,7 @@ int conf_match_item(ConfigFile *conf, ConfigEntry *cep, SecurityGroup **block)
        }
        else if (!strcmp(cep->name, "exclude-security-group"))
        {
- unreal_add_names(&s->security_group, cep);
+ unreal_add_names(&s->exclude_security_group, cep);
        }
        else if (!strcmp(cep->name, "exclude-rule"))
        {

Issue History

Date Modified Username Field Change
2023-10-12 10:00 BlackBishop New Issue
2023-10-12 18:48 syzop Assigned To => syzop
2023-10-12 18:48 syzop Status new => resolved
2023-10-12 18:48 syzop Resolution open => fixed
2023-10-12 18:48 syzop Fixed in Version => 6.1.2.3
2023-10-12 18:48 syzop Note Added: 0023057