View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0006418unrealinstallingpublic2024-06-01 00:092024-06-14 09:23
Reporterhnj Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSLinux 
Product Version6.1.5 
Fixed in Version6.1.7 
Summary0006418: build fails when OPEROVERRIDE_VERIFY is enabled
DescriptionError is:
```
gcc -I/home/irc-server-netwichtig/Data/public/software/unrealircd/bug/unrealircd-6.1.5/include -I/home/irc-server-netwichtig/Data/public/software/unrealircd/bug/unrealircd-6.1.5/extras/argon2/include -g -O2 -fno-strict-aliasing -fno-common -funsigned-char -Wall -Wextra -Waggregate-return -Wformat-nonliteral -Wduplicated-cond -Wduplicated-branches -Wparentheses -Wno-pointer-sign -Wno-format-zero-length -Wno-format-truncation -Wno-format-overflow -Wno-unused -Wno-unused-parameter -Wno-unused-but-set-parameter -Wno-char-subscripts -Wno-sign-compare -Wno-empty-body -Wno-pragmas -fno-strict-overflow -D_FORTIFY_SOURCE=2 -fstack-protector-all -Wstack-protector --param ssp-buffer-size=1 -fstack-clash-protection -fcf-protection -fPIC -DPIC -shared -Wl,-export-dynamic -DDYNAMIC_LINKING \
        -o topic.so topic.c
gcc -I/home/irc-server-netwichtig/Data/public/software/unrealircd/bug/unrealircd-6.1.5/include -I/home/irc-server-netwichtig/Data/public/software/unrealircd/bug/unrealircd-6.1.5/extras/argon2/include -g -O2 -fno-strict-aliasing -fno-common -funsigned-char -Wall -Wextra -Waggregate-return -Wformat-nonliteral -Wduplicated-cond -Wduplicated-branches -Wparentheses -Wno-pointer-sign -Wno-format-zero-length -Wno-format-truncation -Wno-format-overflow -Wno-unused -Wno-unused-parameter -Wno-unused-but-set-parameter -Wno-char-subscripts -Wno-sign-compare -Wno-empty-body -Wno-pragmas -fno-strict-overflow -D_FORTIFY_SOURCE=2 -fstack-protector-all -Wstack-protector --param ssp-buffer-size=1 -fstack-clash-protection -fcf-protection -fPIC -DPIC -shared -Wl,-export-dynamic -DDYNAMIC_LINKING \
        -o invite.so invite.c
invite.c: In function ‘cmd_invite’:
invite.c:460:47: error: ‘MODE_SECRET’ undeclared (first use in this function); did you mean ‘UMODE_SECURE’?
  460 | else if (channel->mode.mode & MODE_SECRET || channel->mode.mode & MODE_PRIVATE)
      | ^~~~~~~~~~~
      | UMODE_SECURE
invite.c:460:47: note: each undeclared identifier is reported only once for each function it appears in
invite.c:460:83: error: ‘MODE_PRIVATE’ undeclared (first use in this function); did you mean ‘MSG_PRIVATE’?
  460 | else if (channel->mode.mode & MODE_SECRET || channel->mode.mode & MODE_PRIVATE)
      | ^~~~~~~~~~~~
      | MSG_PRIVATE
make[3]: *** [Makefile:116: invite.so] Error 1
make[3]: Leaving directory '/home/irc-server-netwichtig/Data/public/software/unrealircd/bug/unrealircd-6.1.5/src/modules'
make[2]: *** [Makefile:79: mods] Error 2
make[2]: Leaving directory '/home/irc-server-netwichtig/Data/public/software/unrealircd/bug/unrealircd-6.1.5/src'
make[1]: *** [Makefile:66: build] Error 2
make[1]: Leaving directory '/home/irc-server-netwichtig/Data/public/software/unrealircd/bug/unrealircd-6.1.5/src'
make: *** [Makefile:141: build] Error 2
```
Steps To Reproduce./Config -advanced
Answer 'Yes' to "Do you want to require opers to /invite themselves into a +s or +p channel?"
make
Tagsbug
3rd party modules

Activities

k4be

2024-06-01 12:09

developer   ~0023210

We should probably search the source for compile-time options modifying IRC behavior and move them all to config.

syzop

2024-06-14 09:23

administrator   ~0023216

Fixed in git (future 6.1.7), PR https://github.com/unrealircd/unrealircd/pull/278 by alice.

commit a77ff1f2c82df3039a1d5b9e444dcfca74f80733 (HEAD -> unreal60_dev, origin/unreal60_dev, origin/HEAD)
Author: alice <[email protected]>
Date: Fri Jun 14 08:22:19 2024 +0100

    Fix OPEROVERRIDE_VERIFY option. (#278)
    
    Reported by hnj in https://bugs.unrealircd.org/view.php?id=6418
    
    Appears to have been introduced as part of the 6.x refactor of secret/private channel modes in 8066c13876c7ae2a76f42d657a7d6d092451aa5d
    
    Also adjust message for ERR_OPERSPVERIFY to include channel name.
    This is to correspond closer to other similar numerics around this area, as well as agreeing with the definition within modern.

Issue History

Date Modified Username Field Change
2024-06-01 00:09 hnj New Issue
2024-06-01 00:09 hnj Tag Attached: bug
2024-06-01 12:09 k4be Note Added: 0023210
2024-06-14 09:23 syzop Assigned To => syzop
2024-06-14 09:23 syzop Status new => resolved
2024-06-14 09:23 syzop Resolution open => fixed
2024-06-14 09:23 syzop Fixed in Version => 6.1.7
2024-06-14 09:23 syzop Note Added: 0023216