View Issue Details

IDProjectCategoryView StatusLast Update
0001022unrealircdpublic2003-11-20 19:43
ReporterAngryWolf Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.2-beta16 
Summary0001022: Notice messages sent by any servers shouldn't be checked for badwords
Description
-NickServ- BADWORD2 nickname isn't registered.
-NickServ- If BADWORD2do not change within one minute, I will change BADWORD2 nickname.
-server2.test.com- *** AngryWolf ([email protected]) did a /whois BADWORD3 BADWORD2
Additional Information006 server1.test.com (2) 1
006 |-server2.test.com (1) 2
006 `-services.test.com (7)
007 End of /MAP

AngryWolf is on server2.test.com and NickServ is connecting from services.test.com.

Badwords configuration of server1.test.com:

badword message {
        word "you";
        replace "BADWORD";
};

badword message {
        word "you.";
        replace "BADWORD2";
};

badword message {
        word "on";
        replace "BADWORD3";
};
3rd party modules

Activities

syzop

2003-06-08 01:30

administrator   ~0002942

All the badwords and special chars checking should be done at the sender side IMO. Currently in a A-B-C net we filter msg from A->B 3 times.. that's a bit waste of CPU :p.

codemastr

2003-06-08 05:26

reporter   ~0002944

I agree, the only logical reason I can come up with for doing it the way we currently have it is, server A allows "blah" but server B blocks "blah" but that doesn't see like a good enough reason to waste all that CPU...

syzop

2003-08-12 18:53

administrator   ~0003463

*bump*

syzop

2003-09-05 21:55

administrator   ~0003596

Fixed in .1906.
Btw, u-lines were already excluded from badwords filtering as far as I can see:
[code]
#ifdef STRIPBADWORDS
                if (!(IsULine(acptr) || IsULine(sptr)) &&
                    IsFilteringWords(acptr))
                    sendto_message_one(acptr, sptr,
                        parv[0], newcmd, nick,
                        stripbadwords_message(parv[2]));
                else
#endif
                    sendto_message_one(acptr,
                        sptr, parv[0], newcmd, nick, parv[2]);
[/code]

Anyway, removed badwords&color filtering of remote msgs since I wanted to do that already a year ago coz it's a waste of CPU.

Issue History

Date Modified Username Field Change
2003-06-05 20:10 AngryWolf New Issue
2003-06-08 01:30 syzop Note Added: 0002942
2003-06-08 05:26 codemastr Note Added: 0002944
2003-06-29 01:51 syzop Note View State: 2942: public
2003-08-12 18:53 syzop Note Added: 0003463
2003-09-05 21:55 syzop Status new => resolved
2003-09-05 21:55 syzop Resolution open => fixed
2003-09-05 21:55 syzop Assigned To => syzop
2003-09-05 21:55 syzop Note Added: 0003596
2003-11-20 19:43 syzop Status resolved => closed