View Issue Details

IDProjectCategoryView StatusLast Update
0001121unrealircdpublic2003-11-20 19:43
ReporterAngryWolf Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.2-beta17 
Summary0001121: module coding & static functions
Description1. /rehash bug

I think there is something wrong with the /rehash command. When I use the local server name for the first parameter, and an option for the second, the option is ignored.

irc.localserver.com << /rehash irc.l* -motd
irc.localserver.com >> *** Notice - Loading IRCd configuration ..
irc.localserver.com >> *** Notice - Configuration loaded without any problems ..


But it had better reload MOTD files and the rules. I'm saying that because /stats <flag> <server> works for any servers on the network including the server I'm currently on.

2. Documentation mistake

ircd.smotd is missing in section "5. Additional files" in unrealircd.conf.

3. Feature request

It's about module coding. The new hooktypes (local join, local chanmode, etc.) are awesome, but because some useful functions in channel.c (add_invite, add_banid, clean_channelmask, etc) are declared statically, I can't use them within a module. I would use add_banid mainly. Is there a way so I don't have to duplicate such codes in my modules?


3rd party modules

Activities

AngryWolf

2003-07-18 09:29

reporter   ~0003267

I'ld like to extend my bugreport with another point, which I think it would make operflags more clear.

4. Missing operflags in the table below "Certin flags give you other flags by default:"

"Netadmin" also give you "services-admin", "admin" and "global",
"admin" and "services-admin" also give you "global",
and "coadmin" gives you "local" too.

I consider this to be important, since I can see a lof of configuration where netadmin, services-admin and global are defined simultaneously.

AngryWolf

2003-07-19 11:27

reporter   ~0003290

Last edited: 2003-07-19 11:29

5. Another point, now it's a minor bug:

/mode AngryWolf -a
AngryWolf sets modes [AngryWolf :-a]
/mode AngryWolf
+owghraAsxNWzt

/mode AngryWolf -aN
AngryWolf sets modes [AngryWolf :-aN]
/mode AngryWolf
+owghraAsxWzt

/mode AngryWolf -aAwghrsxWzt
AngryWolf sets modes [AngryWolf :-wghaAsxWzt]
/mode AngryWolf
+ora

Somewhy I cannot remove my services-admin flag.

edited on: 07-19-03 11:29

gen_

2003-07-19 14:43

reporter   ~0003291

For your 5th point, the remove of the "a" user-mode works fine with me :

/mode Genius -a
[16:50:18] *** Genius sets mode: -a
/mode Genius
Genius +owghAsxNWt

/mode Genius -aN
[16:51:22] *** Genius sets mode: -aN
/mode Genius
Genius +owghAsxWt

/mode Genius -wghaAsxNWt
[16:52:01] *** Genius sets mode: -wghaAsxNWt
/mode Genius
Genius +o

the services-admin mode is then removable...

AngryWolf

2003-07-19 14:56

reporter   ~0003292

Gosh, I can't reproduce it anymore...

AngryWolf

2003-07-19 15:13

reporter   ~0003293

Last edited: 2003-07-19 15:14

Yes, because now it is doing this:

/mode AngryWolf +a
AngryWolf sets modes [AngryWolf :+a]
/mode AngryWolf +a
AngryWolf sets modes [AngryWolf :+a]
/mode AngryWolf +a
AngryWolf sets modes [AngryWolf :+a]

:-(

edited on: 07-19-03 15:14

gen_

2003-07-19 15:26

reporter   ~0003294

I tried to /mode Genius +a several times, it worked once, when I hadn't the 'a' mode just before. After, it didn't answer anything (this is normal, I already have the 'a' mode..)

/mode Genius -a
[17:39:44] *** Genius sets mode: -a
/mode Genius +a
[17:39:47] *** Genius sets mode: +a
/mode Genius +a
<nothing>
/mode Genius +a
<nothing>

:>

AngryWolf

2003-07-19 15:41

reporter   ~0003295

Last edited: 2003-07-19 15:45

I don't have a clue... Debian, PREFIX_AQ enabled, two links + services,

1st link: OpenSSL 0.9.6c, zlib 1.1.4, gcc 2.95.4
2nd link: OpenSSL 0.9.7b, zlib 1.1.4, gcc 2.95.4

edited on: 07-19-03 15:45

gen_

2003-07-19 16:11

reporter   ~0003296

I don't have services ;) my IRCd (a test-ircd) is on Linux Redhat 7.2 (2.4.7-10). I haven't services (like nickserv, chanserv or anything else...)

muhQ

2003-07-19 18:36

reporter   ~0003299

Some services packages will (un)set this mode depending if you are a services admin or not

AngryWolf

2003-07-20 07:18

reporter   ~0003300

muhQ: Oh, you're right, thanks! After disconnecting Services, +a/-a mode changes are OK. Sorry, I didn't know that trick.

syzop

2003-07-28 15:37

administrator   ~0003361

1: boring, 2: fixed, 3: not looked at, but yes.. some functions(/vars) are static which makes it difficult for module coders, I had the same problem once.

syzop

2003-08-05 00:38

administrator   ~0003408

made most functions in channel.c non-static, they are not added to the header files (yet) however.

Issue History

Date Modified Username Field Change
2003-07-17 08:04 AngryWolf New Issue
2003-07-18 09:29 AngryWolf Note Added: 0003267
2003-07-19 11:27 AngryWolf Note Added: 0003290
2003-07-19 11:29 AngryWolf Note Edited: 0003290
2003-07-19 14:43 gen_ Note Added: 0003291
2003-07-19 14:56 AngryWolf Note Added: 0003292
2003-07-19 15:13 AngryWolf Note Added: 0003293
2003-07-19 15:14 AngryWolf Note Edited: 0003293
2003-07-19 15:26 gen_ Note Added: 0003294
2003-07-19 15:41 AngryWolf Note Added: 0003295
2003-07-19 15:45 AngryWolf Note Edited: 0003295
2003-07-19 16:11 gen_ Note Added: 0003296
2003-07-19 18:36 muhQ Note Added: 0003299
2003-07-20 07:18 AngryWolf Note Added: 0003300
2003-07-28 15:37 syzop Note Added: 0003361
2003-07-28 15:55 syzop Summary A /rehash bug, a documentation mistake and a feature request => module coding & static functions
2003-08-05 00:38 syzop Status new => resolved
2003-08-05 00:38 syzop Resolution open => fixed
2003-08-05 00:38 syzop Assigned To => syzop
2003-08-05 00:38 syzop Note Added: 0003408
2003-11-20 19:43 syzop Status resolved => closed