View Issue Details

IDProjectCategoryView StatusLast Update
0001230unrealircdpublic2003-11-20 19:43
ReporterAngryWolf Assigned Tosyzop  
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Product Version3.2-beta17 
Summary0001230: Badword bugs
Description1. There is memory leak bug too in _conf_badword():

        else if (!strcmp(ce->ce_vardata, "all"))
        {
                AddListItem(copy_badword_struct(ca), conf_badword_channel);
                AddListItem(copy_badword_struct(ca), conf_badword_message);
                AddListItem(copy_badword_struct(ca), conf_badword_quit);
        }

In this case, ca is duplicated 3 times, but isn't freed up.

2. I don't suggest to duplicate ca->expr by using only a memset(), because there are pointers in that structure. This also cause segfault on /rehash (regfree() doesn't work). What I would use instead is regcomp() in copy_badword_struct().
3rd party modules

Activities

syzop

2003-09-05 19:49

administrator   ~0003588

oh that sucks :/.

syzop

2003-09-05 20:12

administrator   ~0003591

Should be fixed now (.1903).

Issue History

Date Modified Username Field Change
2003-09-05 17:10 AngryWolf New Issue
2003-09-05 19:49 syzop Note Added: 0003588
2003-09-05 20:12 syzop Status new => resolved
2003-09-05 20:12 syzop Resolution open => fixed
2003-09-05 20:12 syzop Assigned To => syzop
2003-09-05 20:12 syzop Note Added: 0003591
2003-11-20 19:43 syzop Status resolved => closed