View Issue Details

IDProjectCategoryView StatusLast Update
0001322unrealircdpublic2003-11-20 19:43
ReporterAngryWolf Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.2-beta18 
Summary0001322: A problem with HOOKTYPE_LOCAL_JOIN
DescriptionAbout the thingy:

- Module coders: Moved call to HOOKTYPE_LOCAL_JOIN down to where the JOIN, NAMES, etc
  are already sent... this seems to make more sense since we have a prejoin hook now.

That's OK, but I think the JOIN hook went into a wrong place. Now if someone types /join #ch1,#ch2,#ch3, the 'chptr' parameter of the callback function will always contain "#ch3". I don't think it was a good idea to make the function run only once per /join's. It also breaks compatibility with current modules.
3rd party modules

Activities

syzop

2003-10-28 18:33

administrator   ~0003880

oh then I moved it a bit too far...
I wanted to move it after names, join, and the add_user_to_SFjfdihdslhdsf call because now the user was not yet a member when the thing was called.... let's see ;)

AngryWolf

2003-10-28 18:39

reporter   ~0003881

It's good to see it was only a mistake, /me's happy now. :-)

syzop

2003-10-28 18:48

administrator   ~0003882

Should be fixed in .1964 (didn't test.. didn't even compile.. but it should be ok :p).

Issue History

Date Modified Username Field Change
2003-10-28 17:07 AngryWolf New Issue
2003-10-28 18:33 syzop Note Added: 0003880
2003-10-28 18:39 AngryWolf Note Added: 0003881
2003-10-28 18:48 syzop Status new => resolved
2003-10-28 18:48 syzop Resolution open => fixed
2003-10-28 18:48 syzop Assigned To => syzop
2003-10-28 18:48 syzop Note Added: 0003882
2003-11-20 19:43 syzop Status resolved => closed