View Issue Details

IDProjectCategoryView StatusLast Update
0001463unrealircdpublic2003-12-31 17:31
ReporterErik_Rana Assigned To 
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionopen 
Product Version3.2-beta19 
Summary0001463: no warning if there is too big value on maxperip in config
DescriptionI am running a separate server with CGI:IRC webclient.
And since there are alot of connections from that server to the ircd i need to use the NEW: allow {} / OLD: I:Line block.

I used to have a value of 500 on the maxperip setting.
I suspected that it might have reached that and tryed with 50000.
The problem was that everyone got blocked maybe the ircd ignored the whole setting?

Setting it to 5000 got the whole thing working.

A final solution should either be that there are max values in the config ie. "setting maxperip cant be larger then 9999, if you set it to larger the block will be ignored"
Or the config check should warn that a setting in config is to large then <value> and the whole block with the large setting will be ignored until it is fixed.
Maybe even a logentry?
Steps To ReproduceTry to connect from same host more then the allowed number in the default entry in config NEW: allow {} / OLD: I:Line block
Config example..
allow {
        ip *@*;
        hostname *@*;
        class clients;
        maxperip 2;
};
allow {
        ip <some-ip-number>;
        hostname <hostname>;
        class clients;
        maxperip 50000;
};
3rd party modules

Activities

syzop

2003-12-31 01:05

administrator   ~0004477

confirmed, maxperip is a signed short at the moment so max value is 32767... a check should be added (and prolly make it unsigned too [=max 65535]).

Erik_Rana

2003-12-31 01:39

reporter   ~0004479

I just rememberd a thing.
When i and The_devil was talking about this he mentioned that the ircd has a limit of 1024 connections.
http://www.vulnscan.org/UnrealIrcd/faq/#46

So maybe the max value should follow the max value the server can handle?
In theory it is max number of ports ie 65535 but maybe it is more practical to have a global value and if the user tweaks the server to handle more connections the global value must follow.
But in the same time more settings in a config file is more errors and support :-P

syzop

2003-12-31 04:33

administrator   ~0004481

like <number in maxperip> shouldn't be above MAXCONNECTIONS? nah... no ;). same for class::maxclients..
For example I personally have my class::maxclients at 4000 even though I usually compile with 1024 fds, but sometimes I increase it to 3072 fds and I think it's a bit stupid that I would have to change my whole config... Besides, if we start doing this we will never end... server admins need some brains too ;p.

codemastr

2003-12-31 05:53

reporter   ~0004483

Why exactly would you ever want more than like 10 for the maxperip?

Erik_Rana

2003-12-31 12:55

reporter   ~0004487

Simple :-)
We use CGI:IRC for people that are "beginners" in the world of IRC or they are not so skilled that they can operate much more then a webbrowser and e-mail.
It is a nice webclient. ( http://cgiirc.sourceforge.net/ )
And since it uses IP number converted to hex value@serverhostname the ircd must trust that server to connect more times.
We are rather small with maybe 5-20 connections from the webclient.
But there are bigger sites that nees a couple of hundred connections.

penna22

2003-12-31 14:02

reporter   ~0004488

question: why you just remove maxperip; then so they aren't restricted instead of just makeing it high?

syzop

2003-12-31 17:31

administrator   ~0004490

Fixed in CVS (.2022).
And like penna22 says.. allow::maxperip is optional ;).

Issue History

Date Modified Username Field Change
2003-12-30 23:57 Erik_Rana New Issue
2003-12-31 01:05 syzop Note Added: 0004477
2003-12-31 01:39 Erik_Rana Note Added: 0004479
2003-12-31 04:33 syzop Note Added: 0004481
2003-12-31 05:53 codemastr Note Added: 0004483
2003-12-31 12:55 Erik_Rana Note Added: 0004487
2003-12-31 14:02 penna22 Note Added: 0004488
2003-12-31 17:31 syzop Status new => closed
2003-12-31 17:31 syzop Note Added: 0004490