View Issue Details

IDProjectCategoryView StatusLast Update
0001533unrealircdpublic2004-02-11 14:45
Reporterpenna22 Assigned Tocodemastr 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Summary0001533: commands.so can be unloaded on cvs update -> recompile -> /rehash
Descriptionjust now i did /rehash and commands.so couldn't be loaded because remove_oper_snomask symbol couldn't found. yes i did cvs update then recompiled but did not /restart, still had the old copy running BUT the problem with that is that commands.so get unloaded which should never be
TagsNo tags attached.
3rd party modules

Activities

syzop

2004-02-10 20:54

administrator   ~0004952

that's correct, that shouldn't happen.

syzop

2004-02-10 20:55

administrator   ~0004953

are you using remote includes btw?

penna22

2004-02-10 20:59

reporter   ~0004954

nope i never used them

syzop

2004-02-10 21:02

administrator   ~0004955

ok thanks.
I'm able to reproduce it here too, I'll take a look...

codemastr

2004-02-10 22:08

reporter   ~0004956

Sounds almost like something isn't returning an error code somewhere. Because it says:

*** Notice -- Configuration loaded without any problems ..

Instead it should say that there was a problem at stop...

syzop

2004-02-11 00:34

administrator   ~0004964

if (!files.gl_pathc) {
        globfree(&files);
        config_status("%s:%i: loadmodule %s: failed to load",
            ce->ce_fileptr->cf_filename, ce->ce_varlinenum,
            ce->ce_vardata);
        return -1;
    }
    for (i = 0; i < files.gl_pathc; i++) {
        if ((ret = Module_Create(files.gl_pathv[i]))) {
            config_status("%s:%i: loadmodule %s: failed to load: %s",
                ce->ce_fileptr->cf_filename, ce->ce_varlinenum,
                files.gl_pathv[i], ret);
        }
    }
    globfree(&files);
[..]
    return 1;

I don't know if this has something to do with it.. always returning 1 (success).
This also affects modules where Mod_Test fails btw (or any other error during loading for that matter)... just non-existing file is handled fine.

codemastr

2004-02-11 00:46

reporter   ~0004965

Yeah it seems a return -1 is needed, I'm working on it right now.

codemastr

2004-02-11 03:44

reporter   ~0004966

This should be fixed in .2088, can someone please verify that?

syzop

2004-02-11 04:18

administrator   ~0004969

Yup, confirmed to be fixed.


[05:15:21] -maintest.test.net- *** Notice -- Ein is rehashing server config file
-
unrealircd.conf Rehashing
-
[05:15:22] -maintest.test.net- *** Notice -- Loading IRCd configuration ..
-
[05:15:22] -maintest.test.net- *** Notice -- unrealircd.conf:100: loadmodule src/modules/commands.so: failed to load: tmp/F4F7CD49.commands.so: undefined symbol: sendto_snomasG
-
[05:15:22] -maintest.test.net- *** Notice -- error: IRCd configuration failed to load
-
[05:15:23] -maintest.test.net- *** commands - $Id: l_commands.c,v 1.1.2.52 2004/02/07 15:49:37 syzop Exp $ (Wrapper library for m_ commands)
-
[05:15:23] -maintest.test.net- Hooks: 13 15 16
-
[05:15:23] -maintest.test.net- Override:
-

penna22

2004-02-11 08:20

reporter   ~0004971

thanks for fixing it ;)

Issue History

Date Modified Username Field Change
2004-02-10 18:28 penna22 New Issue
2004-02-10 20:54 syzop Note Added: 0004952
2004-02-10 20:55 syzop Note Added: 0004953
2004-02-10 20:59 penna22 Note Added: 0004954
2004-02-10 21:02 syzop Note Added: 0004955
2004-02-10 22:08 codemastr Note Added: 0004956
2004-02-11 00:34 syzop Note Added: 0004964
2004-02-11 00:46 codemastr Note Added: 0004965
2004-02-11 03:44 codemastr Note Added: 0004966
2004-02-11 04:18 syzop Note Added: 0004969
2004-02-11 08:20 penna22 Note Added: 0004971
2004-02-11 14:45 codemastr Status new => resolved
2004-02-11 14:45 codemastr Resolution open => fixed
2004-02-11 14:45 codemastr Assigned To => codemastr