View Issue Details

IDProjectCategoryView StatusLast Update
0001587unrealircdpublic2004-03-02 19:08
ReporterJoolz Assigned To 
PrioritynormalSeverityminorReproducibilitysometimes
Status closedResolutionopen 
Summary0001587: Remote Include Errors
DescriptionI have a url which I was using fine until Unreal core dumped, seems to be the problem with multiple /rehash's so I applied the urlfix.patch.
However, now when I start up the ircd I get this error:
[error] unrealircd.conf:7: include: error downloading http://URL.REMOVED/servers/retrieve.php?user=REMOVED&pass=REMOVED&file=badwords.conf': Cannot write to tmp/9B8A9127.user> <mode>"; (I've changed the password)
I found a way around this is to comment out the include line, start the ircd, uncomment and rehash. This problem is only occuring with that kind of url AFTER it core dumped. Other servers (which have yet to core dump) are working fine with this url, but I've seen examples of this error on two servers now. Plain urls (without &?= in) are working fine still.
Additional InformationI have a copy of the core dump if needed, but I think the urlfix.patch applies to this.
Using: libcurl/7.11.0 OpenSSL/0.9.7c zlib/1.1.4
FreeBSD 4.8-RELEASE-p14 & FreeBSD 4.9-STABLE
ReleaseID (1.1.1.1.2.1.2.1.2.2100 2004/02/15 05:06:57)
3rd party modules

Activities

Joolz

2004-02-24 12:43

reporter   ~0005179

Also on remote includes, (unrelated to above bug) I've found that if you take out a url from the config, and remove the old url from the http server, when you /rehash Unreal still tries to download from the url, even though it isn't included anymore.
*** Notice -- error: Error downloading http://URL.REMOVED/servers/retrieve.php?user=REMOVED&pass=REMOVED&file=global.conf: The requested URL returned error: 404
It seems that Unreal is reading the config in a weird order so it would try to rehash global.conf and then unrealircd.conf?

codemastr

2004-02-24 16:50

reporter   ~0005182

That's because if we don't do it that way, the entire ircd will freeze up while a /rehash occurs. I'll try and think of a way around this but I doubt it will be in 3.2 since it will require some major rewrites.

Joolz

2004-02-24 16:52

reporter   ~0005183

The problem is that the current way of doing it means that it's impossible to rehash the ircd if the url is broken or down or inaccessible, or has simply changed...(because the rehash will fail)

codemastr

2004-02-24 16:59

reporter   ~0005185

As I said, I'll look at it. I understand your concerns. That's not the point, the point is you're presenting a problem, not a solution. Until someone can come up with a solution, there isn't much I can do. I implemented it the way I did because of the simple fact that I could not come up with a better solution.

syzop

2004-02-25 16:28

administrator   ~0005198

[about the original bugreport...]
This should be fixed in .2146, I found a zero terminate bug which gave me funny filenames like 'tmp/testinclude.php*á' etc, would only happen with '?' urls.
[ http://cvs.ircsystems.net/cgi/viewcvs.cgi/unreal/src/Attic/url.c.diff?r1=1.1.2.12&r2=1.1.2.13&search=None&hideattic=1&only_with_tag=devel ]

codemastr

2004-02-25 16:40

reporter   ~0005205

I think I have an idea on how to fix the bug in the bugnote, I'll try and come up with a better way to do it. Basically we'll still have to (try) to download the "old" file, but if it fails it will detect that the file is no longer specified in the config and therefore will just pretend the error never occurred.

codemastr

2004-02-25 18:22

reporter   ~0005211

Ok, all of these problems should now be fixed. Can you update and confirm that?

syzop

2004-03-02 16:12

administrator   ~0005271

Joolz? :)

Joolz

2004-03-02 18:58

reporter   ~0005272

I haven't been able to update any of the servers because that would mean knocking ~400 users off the server, whilst we're trying to prove our stability. we're also using urls without '?=&' now. As soon as I can update to test I will do and keep you informed, thanks.

syzop

2004-03-02 19:08

administrator   ~0005273

ok I'll just assume it's fixed then :).

Issue History

Date Modified Username Field Change
2004-02-24 12:01 Joolz New Issue
2004-02-24 12:43 Joolz Note Added: 0005179
2004-02-24 16:50 codemastr Note Added: 0005182
2004-02-24 16:52 Joolz Note Added: 0005183
2004-02-24 16:59 codemastr Note Added: 0005185
2004-02-25 16:28 syzop Note Added: 0005198
2004-02-25 16:40 codemastr Note Added: 0005205
2004-02-25 18:22 codemastr Note Added: 0005211
2004-03-02 16:12 syzop Note Added: 0005271
2004-03-02 18:58 Joolz Note Added: 0005272
2004-03-02 19:08 syzop Status new => closed
2004-03-02 19:08 syzop Note Added: 0005273