View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001657unrealinstallingpublic2004-03-16 07:192004-03-19 23:26
Reporterbaafie_ Assigned Tocodemastr 
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
OSFreeBSDOS Version4.8-RELEASE-p14 
Product Version3.2-RC2 
Summary0001657: Usage of environment variables in Config script
DescriptionWhen I attempt to use environment variables in the Config script, the following occurs during compilation:

cd modules; make 'CFLAGS=-I../include -I../download/Unreal3.2/extras/regexp/include -pipe -g -O2 -funsigned-char -I/usr/local/ssl/include -DZIP_LINKS -I../curl/include -DUSE_LIBCURL -export-dynamic -L/usr/local/ssl/lib ' 'CC=gcc' 'IRCDLIBS=-lcrypt -lz -L../curl/lib -lcurl -L../ares/lib -lz -lssl -lcrypto -lares -L../extras/regexp/lib -ltre' 'LDFLAGS=' 'IRCDMODE=711' 'BINDIR=OME/ircd-test/ircd' 'INSTALL=/usr/bin/install' 'INCLUDEDIR=../include' 'IRCDDIR=OME/ircd-test' 'MANDIR=' 'RM=/bin/rm' 'CP=/bin/cp' 'TOUCH=/usr/bin/touch' 'RES=' 'SHELL=/bin/sh' 'STRTOUL=' 'CRYPTOLIB=-lssl -lcrypto' 'CRYPTOINCLUDES=' 'URL=url.o' all

Note that instead of properly resolving the $HOME variable, Config uses the variable name, producing "OME/ircd-test" as a path name. Could this behaviour be changed?

Of course, if you run ./configure directly it does work as expected.
Steps To ReproduceRun Config, use environment variables in the path name.
TagsNo tags attached.
3rd party modules

Activities

2004-03-16 21:02

 

Config (14,905 bytes)

baafie_

2004-03-16 21:03

reporter   ~0005513

Last edited: 2004-03-16 21:04

 I've taken the liberty of modifying the Config script so that any environment variable in any pathname entered is evaluated.

I hope this is useful :)

(the edited Config script is attached)

edited on: 2004-03-16 21:04

codemastr

2004-03-18 19:34

reporter   ~0005536

I don't mind adding the env var support, but here's the thing, your patch converts all our tabs into spaces, which is not something I want. Can you submit this patch with just the changes for the variables? If you can, I'll gladly add it.

2004-03-18 20:09

 

Config.tabs (13,454 bytes)

baafie_

2004-03-18 20:09

reporter   ~0005538

There you go.

syzop

2004-03-19 18:10

administrator   ~0005550

Config.diff attached (diff between current Config and Config.tabs). Probably get rid of the '# modified' marks etc. This eval stuff will work on all platforms I suppose (basic /bin/sh)?

2004-03-19 18:11

 

Config.diff (1,153 bytes)

baafie_

2004-03-19 18:27

reporter   ~0005551

eval is a tcl built-in, so I guess it's part of any base unix-like system.

codemastr

2004-03-19 19:01

reporter   ~0005552

Syzop, we already use eval so it should be fine.

if [ "`eval echo -n 'a'`" = "-n a" ] ; then
        c="\c"
else
        n="-n"
fi

syzop

2004-03-19 19:03

administrator   ~0005553

Good. Then I would say go ahead :).

codemastr

2004-03-19 23:26

reporter   ~0005554

Patch added in .2191

Issue History

Date Modified Username Field Change
2004-03-16 07:19 baafie_ New Issue
2004-03-16 21:02 baafie_ File Added: Config
2004-03-16 21:03 baafie_ Note Added: 0005513
2004-03-16 21:04 baafie_ Note Edited: 0005513
2004-03-18 19:34 codemastr Note Added: 0005536
2004-03-18 20:09 baafie_ File Added: Config.tabs
2004-03-18 20:09 baafie_ Note Added: 0005538
2004-03-19 18:10 syzop Note Added: 0005550
2004-03-19 18:11 syzop File Added: Config.diff
2004-03-19 18:27 baafie_ Note Added: 0005551
2004-03-19 19:01 codemastr Note Added: 0005552
2004-03-19 19:03 syzop Note Added: 0005553
2004-03-19 23:26 codemastr Status new => resolved
2004-03-19 23:26 codemastr Resolution open => fixed
2004-03-19 23:26 codemastr Assigned To => codemastr
2004-03-19 23:26 codemastr Note Added: 0005554