View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001735 | unreal | ircd | public | 2004-04-15 02:54 | 2004-04-16 18:55 |
| Reporter | fez | Assigned To | |||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | open | ||
| Product Version | 3.2-RC2 | ||||
| Summary | 0001735: module parameters for commands like /sajoin | ||||
| Description | well i was looking through the source and noticed,.. src/modules/m_sajoin.c, line 100 if (parc != 3) should really be if (parc < 3) as it stands, if you do something like /sajoin fez #test someparam you get the error message: not enough parameters.... Which isn't really what the error is...... so,... either you should make it ignore the extra params, or give an error like "too many params".... obviously this is a trivial "bug" (if you even would call it that) -- fez | ||||
| 3rd party modules | |||||
|
|
also this quite possibly exists in other commands......... |
|
|
If helps: [angrywolf@localhost Unreal]$ grep -R 'parc[[:space:]]\+!=' . ./src/modules/m_sajoin.c: if (parc != 3) ./src/modules/m_sapart.c: if (parc != 3) ./src/modules/m_svsjoin.c: if (parc != 3 || !(acptr = find_person(parv[1], NULL))) ./src/modules/m_svspart.c: if (parc != 3 || !(acptr = find_person(parv[1], NULL))) return 0; That's all I could find. |
|
|
"Fixed" (sajoin, sapart) |
