View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001736 | unreal | ircd | public | 2004-04-15 03:42 | 2004-04-15 12:19 |
| Reporter | fez | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Product Version | 3.2-RC2 | ||||
| Summary | 0001736: (Another...) /rehash module problem | ||||
| Description | Ok, well there's a slight problem with /rehashing modules,... all the modules will be loaded multiple times if one of the modules fails to load properly due to some error like undefined symbol... [02:10] -eos.xevion.net- *** defizzer - $Id: defizzer.c,v 1.1.4.6 2004/03/07 22:26:04 syzop Exp $ (de-Fizzer) [3RD] [02:10] -eos.xevion.net- *** commands - $Id: l_commands.c,v 1.1.4.27 2004/03/07 22:26:14 syzop Exp $ (Wrapper library /rehash [02:10] -eos.xevion.net- *** Notice -- Loading IRCd configuration .. [02:10] -eos.xevion.net- *** Notice -- unrealircd.conf:9: loadmodule src/modules/m_setsince.so: failed to load: tmp/8DBD68F6.m_setsince.so: undefined symbol: IsUline [02:10] -eos.xevion.net- *** Notice -- error: IRCd configuration failed to load [02:10] -eos.xevion.net- *** defizzer - $Id: defizzer.c,v 1.1.4.6 2004/03/07 22:26:04 syzop Exp $ (de-Fizzer) [3RD] [02:10] -eos.xevion.net- *** commands - $Id: l_commands.c,v 1.1.4.27 2004/03/07 22:26:14 syzop Exp $ (Wrapper library for m_ commands) [3RD] [02:10] -eos.xevion.net- *** defizzer - $Id: defizzer.c,v 1.1.4.6 2004/03/07 22:26:04 syzop Exp $ (de-Fizzer) [3RD] [02:10] -eos.xevion.net- *** commands - $Id: l_commands.c,v 1.1.4.27 2004/03/07 22:26:14 syzop Exp $ (Wrapper library for m_ commands) [02:10] -eos.xevion.net- Hooks: 8 13 15 16 [02:10] -eos.xevion.net- Override: Now obviously this problem would be avoided if the coder (me :P) wasn't an idiot who made IsUline instead of IsULine, but still, if an error like this occurs during /rehash, the other modules shouldn't be loaded into the ircd multiple times....... -- fez | ||||
| 3rd party modules | |||||
|
|
Sounds like we're just missing a call to unload_all_testing_modules() or whatever the function is. I'll look into it. |
|
|
Oh I just fixed it [.2221]... I should have done 'assigned' instead of 'confirmed' I guess ;p. Anyway, could you confirm that this is the right solution (certainly looked like that, but...): http://cvs.ircsystems.net/cgi/viewcvs.cgi/unreal/src/s_conf.c.diff?r2=1.1.1.1.6.1.2.354&only_with_tag=devel&r1=1.1.1.1.6.1.2.353&diff_format=l This is added to the 'if config_load() failed branch' which was missing those calls, the 'if config_test() failed branch' did have them. I dunnow if the unload_notloaded_includes() will fix any other bug too, but perhaps? ;) |
|
|
correction: I ment 'if load_conf() failed' of course ;). |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2004-04-15 03:42 | fez | New Issue | |
| 2004-04-15 11:19 | syzop | Status | new => confirmed |
| 2004-04-15 11:19 | syzop | Build | => .2220 |
| 2004-04-15 12:11 |
|
Note Added: 0005864 | |
| 2004-04-15 12:18 | syzop | Status | confirmed => closed |
| 2004-04-15 12:18 | syzop | Note Added: 0005865 | |
| 2004-04-15 12:19 | syzop | Status | closed => feedback |
| 2004-04-15 12:19 | syzop | Resolution | open => reopened |
| 2004-04-15 12:19 | syzop | Note Added: 0005866 | |
| 2004-04-15 12:19 | syzop | Status | feedback => closed |
