View Issue Details

IDProjectCategoryView StatusLast Update
0001768unrealircdpublic2004-05-20 11:54
Reporterthunderbirdjl Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionopen 
Product Version3.2 
Summary0001768: Add option to increase the maximum number of channel bans
DescriptionWould like to see an option implemented in either the ./Config script or unrealircd.conf where the maximum number of bans for a channel can be defined. Currently, you can increase the number of MaxBans by editing include/struct.h and increasing the MAXBANS & MAXBANLENGTH settings. However, by doing this, the Unreal Dev's have stated that you are modifying the source, thus losing their support.
Additional InformationCurrent limit is 60, which for some channels with thousands of people is not enough. There is not always an IRCop on duty to hand out glines to troublemakers.
3rd party modules

Activities

vonitsanet

2004-04-30 08:53

reporter   ~0005961

Last edited: 2004-04-30 08:56

My opinion is that must be added an option for all these:
MAXBANS
NICKLEN (i'm not sure if this is already exists or not)
TOPICLEN
KICKLEN
MAXTARGETS
AWAYLEN
WATCH
SILENCE (i'm not sure if this is already exists or not)
MODES

edited on: 2004-04-30 08:56

aquanight

2004-04-30 13:35

reporter   ~0005963

I hope you understand the memory complications that can arise with such options ;) . (Of course, setting NICKLEN=9 would be kinda funny, though it's RFC-compliant. Though users come off of EFnet wouldn't mind ;) .)

Remember, the RFC requires a 512 byte limit be imposed on incoming commands. Any longer and the command is invalid. This limit includes the terminating CRLF, so the actual limit on message is 510 bytes. With some really long channel names, you'd be lucky to even fit a 307 (the current limit) character topic into the limit, especially if unicode comes into play (or not).

Changing some of these would probably break clients, and for some you shouldn't need more than what the current limit is.

If you are running out of ban space, then maybe you need to merge a few.

tabrisnet

2004-05-02 16:47

reporter   ~0005976

Max-Silences is already a runtime option (per bug 1486)
Watch is 128. but yeah... some people might want this bigger.
not sure we need MODES to be more or not. comments?
and MAXTARGETS is a abuse limiter and practical limit. 20 targets, 30 char nicks... well, there's no room for the command let alone the message. xref aquanight's comments.

codemastr

2004-05-02 17:03

reporter   ~0005977

MODES definately will *not* be changable. It will only cause problems. It will result in desync between servers if you change it on one but not all. That's simply never going to happen. Furthermore, we don't want to have people answer 30 questions to run ./Config! If they want to change all these things, why can't they just go to config.h and change them? I mean, if you don't know enough to look there, then you probably shouldn't be touching them anyway.

And for anything in config.h, you are perfectly fine changing it without losing support, that's why the file is there. The reason some things aren't in config.h is because we don't want them changed. Changing the maxbans will only lead to confusion. "I set it to 5000 and it lets me have 30, why?" People won't realize how the length fits into it. Therefore, we feel it is better to just leave it alone.

syzop

2004-05-20 11:54

administrator   ~0006345

I agree with codemastr on this.
Changing this stuff can easily break stuff etc.

Changing max bans (and max total banlength) is personally fine with me, as long as it's mentioned in the bugreport. However most other things like changing topiclen, kicklen, nicklen, modes (omg), etc is something I would NOT support since they directly affect buffer lengths and things like that, so...

Issue History

Date Modified Username Field Change
2004-04-30 04:05 thunderbirdjl New Issue
2004-04-30 08:53 vonitsanet Note Added: 0005961
2004-04-30 08:56 vonitsanet Note Edited: 0005961
2004-04-30 13:35 aquanight Note Added: 0005963
2004-05-02 16:47 tabrisnet Note Added: 0005976
2004-05-02 17:03 codemastr Note Added: 0005977
2004-05-20 11:54 syzop Status new => closed
2004-05-20 11:54 syzop Note Added: 0006345