View Issue Details

IDProjectCategoryView StatusLast Update
0001930unrealinstallingpublic2004-07-18 18:24
Reporterfez Assigned Tocodemastr 
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSLinuxOS Version2.4.x
Product Version3.2.1 
Summary0001930: a suggestion for Config and src/modules/Makefile.in
Descriptionwell, i've given this some thought...
I requested a while back that a Config option be added to compile only commands.so instead of that and m_*.so, and it was considered but decided against because it was thought it wouldn't bring that much of an improvement,,,,

Well I got to thinking, the main reason i made that request is because of the fact that the src/modules/Makefile[.in] makes a single call to gcc to compile all of commands.so, without compiling each .c to a .o first, and as a result it takes FOREVER (and on my P166, which gets kind of touchy and sometimes has the nasty sig11 problem, it sometimes takes several attempts at make to get it compiled and it takes FOREVERPLUSONE).... soo.....

I've brought my request down a notch - instead of requesting that only commands.so be compiled, i'd just request that we at least compile each .c into a .o before linking. This has a few benefits:

1. that single call to gcc for commands.so doesn't take FOREVER
2. if a user/module coder wanted to make just a small change to one of the commands.so commands like m_whois.c, they wouldn't have to recompile ALL the commands to make the change take effect. make would see that only m_whois.o needs to be updated, then just relink commands.so from the already existing .o's
3. i think it's good practice to have all the .o's anyway, and it would also potentially make it easier to in the future implement a ./Config option to only compile commands.so (although -DDYNAMIC_LINKING isn't used when compiling the .o's, only the .so's..).


I've attached the proposed src/modules/Makefile.in for you to review, with any changes duly noted

Thoughts?

 - fez
TagsNo tags attached.
Attached Files
Makefile.in (23,364 bytes)
3rd party modules

Activities

syzop

2004-07-08 11:13

administrator   ~0006926

Yeah, doesn't sound too bad.
(although the if-the-user-modified-unreal isn't exactly a good argument to me since I just beat those guys to death ;p.. but it would be useful to myself & lowmem boxes)

codemastr

2004-07-18 18:24

reporter   ~0007142

Added in .102

Issue History

Date Modified Username Field Change
2004-07-08 05:54 fez New Issue
2004-07-08 05:54 fez File Added: Makefile.in
2004-07-08 11:13 syzop Note Added: 0006926
2004-07-12 15:47 codemastr Status new => assigned
2004-07-12 15:47 codemastr Assigned To => codemastr
2004-07-18 18:24 codemastr Status assigned => resolved
2004-07-18 18:24 codemastr Resolution open => fixed
2004-07-18 18:24 codemastr Note Added: 0007142