View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002607 | unreal | ircd | public | 2005-07-31 11:05 | 2005-08-02 20:32 |
| Reporter | Daedalon | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | wont fix | ||
| Product Version | 3.2.3 | ||||
| Summary | 0002607: If connecting from an IP, /WHOIS shows it double | ||||
| Description | In 1376 it was added that IP shows after the hostname in /WHOIS. This has however been done so that it shows even if the hostname is IP, so the IP gets displayed twice. -!- Nick [[email protected]] -!- ircname : Nick Name -!- modes : -!- : is connecting from *@example.org 192.168.0.1 That is fine, but this isn't: -!- Nick2 [[email protected]] -!- ircname : Nick Nameless -!- modes : -!- : is connecting from *@192.168.0.2 192.168.0.2 So please make the IP displayed only once in the "is connecting from" line. Improves readability, looks less amateurish, saves bandwidth and saves the rain forests. Two additional questions about the WHOIS that might not deserve a bug report of their own: Why is the modes line indented one space more than the others? The colon (:) is one column more to the right than on the other lines. Why is there a "*@" in the "is connecting from" line? I can't see how it provides any information, only clutters the readability of the line. I think this would be a more ideal display (notice also the added brackets / parentheses): -!- : is connecting from example.org (192.168.0.1) | ||||
| Steps To Reproduce | /WHOIS on anyone who is connecting with an IP hostname. | ||||
| 3rd party modules | |||||
|
|
The IP is sidplayed twice, because that is how the numeric is set up. The numeric displays information as: :is connecting from <HOST> <IP> Meaning there must be a host, and there must be an IP. What else will you put as a host? The thing about more than one colon: that is the way your client (I am assuming irssi) formats the line when it displays it to you. Try looking at it in a different client, or look at a debug output of the line. About the readability: this is something that can easily be done with scripts. It is not the IRCd's responsability to improve readability. It is the clients responsability. It is easy to make a script to drop the "*@", and add parentheses to the IP portion of the line. |
|
|
[quote]Improves readability, looks less amateurish, saves bandwidth and saves the rain forests.[/quote] And breaks scripts / clients? [quote]Why is there a "*@" in the "is connecting from" line?[/quote] Same story. [quote]Why is the modes line indented one space more than the others? The colon (:) is one column more to the right than on the other lines.[/quote] I don't see any extra (useless) identation. I agree with Bugz here.. It is not the IRCd's responsability to improve readability, we mainly focus on technical correctness. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-07-31 11:05 | Daedalon | New Issue | |
| 2005-07-31 14:17 | Stealth | Note Added: 0010297 | |
| 2005-07-31 17:52 | syzop | Note Added: 0010301 | |
| 2005-08-02 20:32 | syzop | Status | new => closed |
| 2005-08-02 20:32 | syzop | Resolution | open => fixed |
| 2005-08-02 20:32 | syzop | Resolution | fixed => wont fix |
