View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002651 | unreal | ircd | public | 2005-09-29 06:52 | 2015-08-08 18:03 |
| Reporter | w00t | Assigned To | syzop | ||
| Priority | normal | Severity | trivial | Reproducibility | N/A |
| Status | closed | Resolution | no change required | ||
| Product Version | 3.2.3 | ||||
| Summary | 0002651: Cleanup of s_serv.c m_info stuff | ||||
| Description | Looking over s_serv.c, I noticed that for some odd reason, /info was split into two functions - something I found odd, as m_info_send was only ever called from m_info, kind of wasteful. (Especially as now modules can just do_cmd()) I merged it into m_info on the following patch based on 3.2.3 | ||||
| Attached Files | info_merge-patch (8,040 bytes) | ||||
| 3rd party modules | |||||
|
|
Hm.. I presume it was simply moved to a subfunction to make it look cleaner (instead of having everything indented 2 tabs). Though it could be made more clean by moving the duplicating me.name RPL_INFO sptr->name stuff to something like the sendnotice() style (but then sending RPL_INFO). Btw, what has do_cmd to do with it? :P |
|
|
If modules need to do /info crap, they can just do_cmd rather than calling that func :p. I moved it there yes, to make it look cleaner, but also to fit more into the way /credits and /dalinfo work :p |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-09-29 06:52 | w00t | New Issue | |
| 2005-09-29 06:52 | w00t | File Added: info_merge-patch | |
| 2005-09-30 20:57 | syzop | Note Added: 0010539 | |
| 2005-10-01 06:38 | w00t | Note Added: 0010542 | |
| 2007-04-27 04:38 |
|
Status | new => acknowledged |
| 2015-08-08 18:03 | syzop | Status | acknowledged => closed |
| 2015-08-08 18:03 | syzop | Assigned To | => syzop |
| 2015-08-08 18:03 | syzop | Resolution | open => no change required |
