View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002983 | unreal | module api | public | 2006-06-22 16:57 | 2007-01-12 17:20 |
| Reporter | Bock | Assigned To | |||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 3.2.6 | ||||
| Summary | 0002983: Improve view map of servers. | ||||
| Description | Imho it's so ugly see, that we see at /map. I send patch, that added additional useful info by command /map | ||||
| Additional Information | Ex: Old: -› n-o-l.bynets.org (23) 6 -› |-nol.bynets.org (1) 111 -› `-solo.bynets.org (46) 50 -› |-vega.bynets.org (0) 84 -› |-z53.bynets.org (3) 52 -› |-GalaNet.Lorien.ByNets.org (2) 60 New: -› nol.bynets.org 1 (0.1%) - num 111 -› `-n-o-l.bynets.org 23 (1.5%) - num 6 -› `-solo.bynets.org 45 (2.9%) - num 50 -› |-vega.bynets.org 0 (0.0%) - num 84 -› |-z53.bynets.org 3 (0.2%) - num 52 -› |-GalaNet.Lorien.ByNets.org 2 (0.1%) - num 60 | ||||
| Attached Files | better.view.map.diff (2,991 bytes) | ||||
| 3rd party modules | |||||
| related to | 0003300 | closed | new and better map view style |
|
|
1.) it looks like you broke /map. You have two nodes with a ` which should not happen. 2.) all you added was the percentage of users. We originally had this, and removed it for two reasons. One, I don't see why it's "useful" (feel free to try to convince me otherwise) and two, people complained about the fact that rounding errors resulted in totals like 99.9% or 100.1%, which there is nothing we can do about. 3.) You have some crazy "allusers" variable, that is calling printf()??? Which further causes problems since Unreal reuses stdout as a client socket. Hence, this could potentially result in that variable being sent to a client each time /map is used. 4.) We generally shy away from changing numerics because it breaks what clients expect. As I said, feel free to try to convince me I'm wrong, but as of right now, I don't see a reason to add this patch to Unreal. |
|
|
1) map not broken, example old was used by server n-o-l.bynets.org, new was used by nol.bynets.org. 2) I'm not coder, I simply take from "We originally had this, and removed it for two reasons". It just suggest. |
|
|
I agree that percentages are pointless, and can be had from services side. having it in /map is useless! :) |
|
|
I'm considering removing numerics from /MAP output for non-opers. I wonder why we are even showing this info to normal users, why would they care? Or is there just to confuse them? ;) Probably the usual story of 'didn't think of hiding it for normal users' I guess. EDIT: This doesn't have much to do with the patch/suggestedthingy in this bugreport, it just seems the right place to bring such a change up. |
|
|
yea, I agree. What for to people to see what is not necessary to them? And this bug you can close. |
|
|
can be closed :p |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-06-22 16:57 | Bock | New Issue | |
| 2006-06-22 16:57 | Bock | File Added: better.view.map.diff | |
| 2006-06-22 22:13 |
|
Note Added: 0012001 | |
| 2006-06-23 01:32 | Bock | Note Added: 0012004 | |
| 2006-06-25 23:42 | Bricker | Note Added: 0012021 | |
| 2006-08-03 19:06 | syzop | Note Added: 0012142 | |
| 2006-08-03 19:07 | syzop | Note Edited: 0012142 | |
| 2006-08-04 01:03 | Bock | Note Added: 0012149 | |
| 2007-01-12 17:20 | syzop | Status | new => closed |
| 2007-01-12 17:20 | syzop | Note Added: 0013051 | |
| 2007-01-12 17:20 | syzop | Resolution | open => no change required |
| 2007-04-28 07:51 | syzop | Relationship added | related to 0003300 |
| 2017-01-06 15:48 | syzop | Category | module => module api |
