View Issue Details

IDProjectCategoryView StatusLast Update
0003003unrealircdpublic2006-07-21 05:42
ReporterDelGurthAssigned Tosyzop 
PrioritynormalSeveritytrivialReproducibilityalways
Status resolvedResolutionfixed 
Platformi386OSLinux, FreeBSDOS Version2.4.32,5.1
Product Version3.2.4 
Target VersionFixed in Version3.2.6 
Summary0003003: tld::options::ssl ignored?
DescriptionIn unreal 3.2.3 I could add options { ssl; } to my tld block to show a different motd for the users who are using SSL. In 3.2.4, and now also 3.2.5, that no longer works.
Steps To ReproduceUse this in your config. It will always show the SSL version of the motd. Reverse the tld blocks and you will always get the non SSL version of the motd.

tld {
        mask *@*;
        motd "ircd.motd";
        rules "ircd.rules";
};

tld {
        mask *@*;
        motd "ircd.motd.ssl";
        rules "ircd.rules";
        options {
                ssl;
        };
};
TagsNo tags attached.
3rd party modules

Activities

DelGurth

2006-07-20 09:35

reporter   ~0012077

Last edited: 2006-07-20 20:37

The error is in src/s_conf.c method "_conf_tld(ConfigFile *conf, ConfigEntry *ce)"

for (cepp = cep->ce_entries; cepp; cepp = cepp->ce_next)
{
if (!strcmp(cep->ce_varname, "ssl"))
ca->options |= TLD_SSL;
else if (!strcmp(cep->ce_varname, "remote"))
ca->options |= TLD_REMOTE;
}

Should be changed into (if I understand C good enough, I'm a java programmer;)

for (cepp = cep->ce_entries; cepp; cepp = cepp->ce_next)
{
if (!strcmp(cepp->ce_varname, "ssl"))
ca->options |= TLD_SSL;
else if (!strcmp(cepp->ce_varname, "remote"))
ca->options |= TLD_REMOTE;
}

It is broken somewhere between unreal 3.2.2 and 3.2.3

syzop

2006-07-21 05:42

administrator   ~0012078

Fixed in .547:
- Fixed tld::options:: not working properly, reported by DelGurth (0003003).

Issue History

Date Modified Username Field Change
2006-07-20 08:55 DelGurth New Issue
2006-07-20 09:35 DelGurth Note Added: 0012077
2006-07-20 20:37 DelGurth Note Edited: 0012077
2006-07-21 05:42 syzop Status new => resolved
2006-07-21 05:42 syzop Fixed in Version => 3.2.6
2006-07-21 05:42 syzop Resolution open => fixed
2006-07-21 05:42 syzop Assigned To => syzop
2006-07-21 05:42 syzop Note Added: 0012078