View Issue Details

IDProjectCategoryView StatusLast Update
0003102unrealircdpublic2006-11-03 07:46
ReporteravbAssigned Tosyzop 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformOSALLOS VersionALL
Product Version3.2.5 
Target VersionFixed in Version3.2.6 
Summary0003102: Ukrainian charset bug
DescriptionWith ukrainian nicks - ukrainian language has no characters 'ÛûÚú', and now it is not possible use "pure-ukrainian" nick without source modification.

'ÀÁÂÃ¥ÄŪÆÇȲ¯ÉÊËÌÍÎÏÐÑÒÓÔÕÖ×ØÙÜÞßàáâã´äåºæç賿éêëìíîïðñòóôõö÷øùüþÿ' (alphabetical order)

russian and ukrainian uses same codepage - windows-1251, so if administrator will want to permit mixed rus/ukr nicks - it can select more than one allowed-nickchars (russian-w1251; ukrainian-w1251; etc).
TagsNo tags attached.
3rd party modules

Activities

syzop

2006-11-01 08:01

administrator   ~0012543

So 'ÛûÚú' should be added?

That's easy to fix.

avb

2006-11-01 09:27

reporter   ~0012544

Last edited: 2006-11-01 09:53

removed, not added ;)

ÛûÚú - russian characters, not ukrainian

i mean, that current "allowed ukrainian characters" allows both, ukrainian and russian nicks, not only ukrainian

EDIT:
'ÛûÚú¨¸Ýý' - need to be removed,
'¥´' - added
full list of ukrainian characters can be found here: http://ru.wikipedia.org/wiki/%D0%A3%D0%BA%D1%80%D0%B0%D0%B8%D0%BD%D1%81%D0%BA%D0%B8%D0%B9_%D0%B0%D0%BB%D1%84%D0%B0%D0%B2%D0%B8%D1%82

syzop

2006-11-01 09:35

administrator   ~0012545

Ok, thanks for the clarification.

Bock

2006-11-01 11:27

reporter   ~0012547

Last edited: 2006-11-01 11:31

You can add and for belorussian language (we forget to remove some russians letters and it be more flexible :p).

if (w1251 || !strcmp(name, "belarussian-w1251"))
    {
        /* supplied by Anton Samets & ss:
         * 128-159, 161, 162, 178, 179 and 223-254
         */
-charsys_addallowed("АБВГДЕЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯабвгдежзийклмнопрстуфхцчшщъыьэюяЁёЎўІі");
+charsys_addallowed("АБВГДЕЖЗЙКЛМНОПРСТУФХЦЧШЫЬЭЮЯабвгдежзйклмнопрстуфхцчшыьэюяЁёЎўІі'");
    }

"'" - it's our "firm sign" (russian "ъ")

Grrr. http://ru.wikipedia.org/wiki/Белорусский_алфавит


and now patch to you..

2006-11-01 11:32

 

charsys.c.diff (472 bytes)

syzop

2006-11-01 11:35

administrator   ~0012548

Thanks Bock, I'll put it in CVS later today ;)

Bock

2006-11-01 14:30

reporter   ~0012549

and now one more file - diff to fixes ukr and blr - (I just find avb (second nick core))) :]

2006-11-01 14:30

 

charsys.c.fix.diff (1,009 bytes)

syzop

2006-11-03 07:46

administrator   ~0012551

charsys.c.fix.diff committed to CVS .571 (and in 3.3* as well):

- Updated ukrainian-w1251 and belarussian-w1251 charsets: some characters were previously
  included that shouldn't. Reported by avb (0003102), patch supplied by Bock.

Thanks :)

Issue History

Date Modified Username Field Change
2006-11-01 07:59 syzop New Issue
2006-11-01 07:59 syzop Reporter syzop => avb
2006-11-01 08:01 syzop Note Added: 0012543
2006-11-01 09:27 avb Note Added: 0012544
2006-11-01 09:29 avb Note Edited: 0012544
2006-11-01 09:35 syzop Note Added: 0012545
2006-11-01 09:35 syzop Status new => acknowledged
2006-11-01 09:46 avb Note Edited: 0012544
2006-11-01 09:47 avb Note Edited: 0012544
2006-11-01 09:53 avb Note Edited: 0012544
2006-11-01 11:27 Bock Note Added: 0012547
2006-11-01 11:31 Bock Note Edited: 0012547
2006-11-01 11:32 Bock File Added: charsys.c.diff
2006-11-01 11:35 syzop Note Added: 0012548
2006-11-01 14:30 Bock Note Added: 0012549
2006-11-01 14:30 Bock File Added: charsys.c.fix.diff
2006-11-03 07:46 syzop Status acknowledged => resolved
2006-11-03 07:46 syzop Fixed in Version => 3.2.6
2006-11-03 07:46 syzop Resolution open => fixed
2006-11-03 07:46 syzop Assigned To => syzop
2006-11-03 07:46 syzop Note Added: 0012551