View Issue Details

IDProjectCategoryView StatusLast Update
0003481unrealircdpublic2007-07-24 22:52
ReporterstskeepsAssigned Tostskeeps 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version4.0-devel 
Target VersionFixed in Version4.0-devel 
Summary0003481: m_cloaking.cpp only errors when all of the keys are missing
DescriptionAs above. Problem lies in this code:

if (!key1 && !key2 && !key3 && !key4)
                        throw ModuleException("You have not defined cloak keys for m_cloaking!!

Should have been:

if (!key1 || !key2 || !key3 || !key4)
                        throw ModuleException("You have not defined cloak keys for m_cloaking!!
Steps To Reproduce<cloak key1="0x2AF39F40"
       key2="0x78E10B32"
       key3="0x4F2D2E82"
        key4="0x043A4C81"
        prefix="mynet">
^ works

<cloak
        prefix="mynet">

^ doesn't work:

[*] There was an error loading the module 'm_cloaking.so': Factory function of A Module threw an exception: You have not defined cloak keys for m_cloaking!!! THIS IS INSECURE AND SHOULD BE CHECKED!

<cloak
       key1="0x2AF39F40"
       key2="0x78E10B32"
        prefix="mynet">

works. (and it really shouldn't?)



TagsNo tags attached.
3rd party modules

Activities

stskeeps

2007-07-23 16:08

reporter   ~0014566

-Actually- fixed in r86 wih the insp sync.

owine

2007-07-23 16:13

reporter   ~0014567

Second fix accepted. Code checking validity of cloak keys now correctly matches if one field is 0 instead of all fields being 0.

owine

2007-07-24 21:53

reporter   ~0014588

Re-tested and the module does NOT work correctly. With all cloak keys set correctly the module throws an exception.

owine

2007-07-24 22:09

reporter   ~0014589

Conflicting report on if this fixed worked. Will continue to update.

owine

2007-07-24 22:52

reporter   ~0014590

Apologies, this was fixed correctly.

Issue History

Date Modified Username Field Change
2007-07-23 15:46 stskeeps New Issue
2007-07-23 15:46 stskeeps QA => Not touched yet by developer
2007-07-23 15:46 stskeeps U4: Need for upstream patch => No need for upstream InspIRCd patch
2007-07-23 15:46 stskeeps U4: Upstream notification of bug => Not decided
2007-07-23 15:46 stskeeps U4: Contributor working on this => None
2007-07-23 15:58 stskeeps QA Not touched yet by developer => Fixed by developer, needs QA testing
2007-07-23 15:58 stskeeps Status new => resolved
2007-07-23 15:58 stskeeps Fixed in Version => 4.0-devel
2007-07-23 15:58 stskeeps Resolution open => fixed
2007-07-23 15:58 stskeeps Assigned To => stskeeps
2007-07-23 16:08 stskeeps Note Added: 0014566
2007-07-23 16:13 owine QA Fixed by developer, needs QA testing => QA has accepted the fix
2007-07-23 16:13 owine Note Added: 0014567
2007-07-24 21:53 owine QA QA has accepted the fix => QA has declined the fix
2007-07-24 21:53 owine Note Added: 0014588
2007-07-24 21:53 owine Resolution fixed => reopened
2007-07-24 22:09 owine Note Added: 0014589
2007-07-24 22:52 owine QA QA has declined the fix => QA has accepted the fix
2007-07-24 22:52 owine Note Added: 0014590
2007-07-24 22:52 owine Resolution reopened => fixed