View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003641 | unreal | ircd | public | 2008-02-20 00:38 | 2013-05-20 01:23 |
| Reporter | fez | Assigned To | |||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | x86 | OS | windows | OS Version | 2003 |
| Product Version | 3.2.7 | ||||
| Fixed in Version | 3.4-alpha1 | ||||
| Summary | 0003641: possible crash in sendto_channel_butone | ||||
| Description | src/send.c has pretty shoddy use of va_start and va_end macros. I cleaned them up a lot. Incidently I fixed a possible crash in sendto_channel_butone. | ||||
| Steps To Reproduce | write a module that does something like... sendto_channel_butone(&me, &me, chptr, "blah"); or sendto_channel_butone(NULL, &me, chptr, "blah"); ircd crashes on windows only. Apparently linux is a little more liberal with abuses of va_start. Attached is a .diff patch (compared to 3.2.7 release's src/send.c) | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| 3rd party modules | |||||
|
|
Submitted new send.c to SVN, revision 265 |
|
|
figure out if this is still a problem, and re-fix ? |
|
|
send.c is a minefield of bad va_list macro use and code duplication. i'm going to rewrite it when we switch to linebufs in 3.4. |
|
|
http://hg.unrealircd.org/hg/unreal/rev/c312ceab2bef |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-02-20 00:38 | fez | New Issue | |
| 2008-02-20 00:38 | fez | File Added: send.c.diff | |
| 2008-02-20 01:35 | fez | File Added: send.c | |
| 2008-02-20 20:12 | Stealth | Status | new => assigned |
| 2008-02-20 20:12 | Stealth | Assigned To | => Stealth |
| 2008-02-20 20:13 | Stealth | QA | => Not touched yet by developer |
| 2008-02-20 20:13 | Stealth | U4: Need for upstream patch | => No need for upstream InspIRCd patch |
| 2008-02-20 20:13 | Stealth | Status | assigned => resolved |
| 2008-02-20 20:13 | Stealth | Fixed in Version | => 3.3-alpha0 |
| 2008-02-20 20:13 | Stealth | Resolution | open => fixed |
| 2008-02-20 20:13 | Stealth | Note Added: 0015161 | |
| 2008-02-20 20:16 | Stealth | Note Edited: 0015161 | |
| 2011-07-19 18:10 | syzop | Note Added: 0016719 | |
| 2011-07-19 18:10 | syzop | Assigned To | Stealth => |
| 2011-07-19 18:10 | syzop | Status | resolved => needs re porting |
| 2012-11-25 18:00 |
|
Note Added: 0017245 | |
| 2013-05-20 01:22 |
|
Note Added: 0017609 | |
| 2013-05-20 01:22 |
|
Status | needs re porting => resolved |
| 2013-05-20 01:22 |
|
Fixed in Version | 3.3-alpha0 => 3.4-alpha1 |
| 2013-05-20 01:22 |
|
Assigned To | => nenolod |
