View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003946 | unreal | ircd | public | 2010-08-22 21:15 | 2013-05-20 21:26 |
| Reporter | tabrisnet | Assigned To | |||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.2.8 | ||||
| Fixed in Version | 3.4-alpha1 | ||||
| Summary | 0003946: CS INVITE noisy due to ircd invite notice | ||||
| Description | Implemented a CS JOIN that calls CS INVITE (if user has access), so that a JOIN may always succeed (regardless of +i, +k, +b, etc). Unfortunately every time a user with access uses CS JOIN (NS AJOIN uses CS JOIN), an invite notice is sent to the channel. For some channels, this is considered annoying. Can we add a SVSINVITE that doesn't do this, or make a configurable option to disable the notice? | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| 3rd party modules | |||||
|
|
I think that this has come up before, with the correct solution being use of some invite numeric instead of an invite notice. |
|
|
unreal-3946-no-invite-channotice.patch: I think that this is the correct way to inform channel members (ops only) of channel invites. |
|
|
How do other ircds deal with this. Do they use the method proposed in the patch? |
|
|
unreal-3946-no-invite-channotice-numeric-345.patch: Use a numeric reply which I found in a random IRC protocol listing online. I can't find it used by anyone in my short search (of just freenode), but using this numeric would kill the NOTICEs and still allow people access to the information if they want it. |
|
|
I could be wrong, and.. it could just be 'coincidence', but AFAICT numerics only get sent in reply to some command [hence RPL_xxx and errors ERR_xxxx]... not 'out of the blue'? I don't know if it's a 'rule' though. And if it's still true. |
|
|
notice vs numeric. numerics IMHO are far easier to parse for scripts (namely mIRC). However, I've found that basic, not so technical users like notices because they usually go to the active window and users have the ability to ignore or "forget" some important information also appears in status. I've encountered this very problem shortly after coding a custom module for a network that used sendto_umode() (server notice). I've already been asked to re-write it as a NOTICE instead because users fail to see the announcements in their status window. In short, keep the ircd invite notice as-is or create a method for admins to choose which method they wish to use. |
|
|
The new cap_invitenotify.so module based on InspIRCd's proposal fixes this bug entirely. We will remove the old notice in a later revision. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-08-22 21:15 | tabrisnet | New Issue | |
| 2010-08-23 05:11 | ohnobinki | Note Added: 0016300 | |
| 2010-08-23 07:11 | ohnobinki | File Added: unreal-3946-no-invite-channotice.patch | |
| 2010-08-23 07:11 | ohnobinki | Note Added: 0016301 | |
| 2010-08-23 07:12 | ohnobinki | Status | new => confirmed |
| 2010-11-15 18:15 | syzop | Note Added: 0016417 | |
| 2010-11-15 18:15 | syzop | Status | confirmed => has patch |
| 2010-12-16 02:28 | ohnobinki | File Added: unreal-3946-no-invite-channotice-numeric-345.patch | |
| 2010-12-16 03:14 | ohnobinki | Note Added: 0016464 | |
| 2010-12-16 21:07 | syzop | Note Added: 0016465 | |
| 2010-12-17 02:50 | katsklaw | Note Added: 0016466 | |
| 2010-12-17 02:53 | katsklaw | Note Edited: 0016466 | |
| 2010-12-17 02:54 | katsklaw | Note Edited: 0016466 | |
| 2010-12-17 03:20 | katsklaw | Note Edited: 0016466 | |
| 2010-12-17 03:24 | katsklaw | Note Edited: 0016466 | |
| 2013-05-20 21:26 |
|
Note Added: 0017642 | |
| 2013-05-20 21:26 |
|
Status | has patch => resolved |
| 2013-05-20 21:26 |
|
Resolution | open => fixed |
| 2013-05-20 21:26 |
|
Assigned To | => nenolod |
| 2013-05-20 21:26 |
|
Fixed in Version | => 3.4-alpha1 |
