View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003996 | unreal | ircd | public | 2011-01-07 00:35 | 2011-01-08 17:32 |
| Reporter | katsklaw | Assigned To | |||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | no change required | ||
| Product Version | 3.2.9-RC1 | ||||
| Summary | 0003996: set::timesynch directive missing | ||||
| Description | Yes I know it defaults to on, but newbies and even us not so newbies that have bad memories *innocent look* will inadvertently fire up Unreal that will be ntp'd on a box that isn't and poof, TS issues with services! | ||||
| Additional Information | I'll submit a patch for this unless someone beats me to it, right now I'm too tired. | ||||
| 3rd party modules | |||||
|
|
So you're saying that this setting is missing from the example.conf? |
|
|
katsklaw@shell2:~/Unreal3.2.orig$ grep "timesync" doc/*conf It is indeed missing and timesynch is enabled by default in src/s_conf.c huge "NO NO" in my humble opinion. To continue my opinion it should be in the example.conf and disabled in the config parser by default. katsklaw@shell2:~/Unreal3.2.orig$ grep "timesync" src/s_conf.c i->timesynch_enabled = 1; i->timesynch_timeout = 3; i->timesynch_server = strdup("193.67.79.202,192.43.244.18,128.250.36.3"); /* nlnet (EU), NIST (US), uni melbourne (AU). All open acces, nonotify, nodns. */ else if (!strcmp(cep->ce_varname, "timesync") || !strcmp(cep->ce_varname, "timesynch")) tempiConf.timesynch_enabled = config_checkval(cepp->ce_vardata,CFG_YESNO); tempiConf.timesynch_timeout = config_checkval(cepp->ce_vardata,CFG_TIME); ircstrdup(tempiConf.timesynch_server, cepp->ce_vardata); else if (!strcmp(cep->ce_varname, "timesync") || !strcmp(cep->ce_varname, "timesynch")) { config_error("%s:%i: set::timesync::%s value out of range (%d), should be between 1 and 5 (higher=unreliable).", cepp->ce_varlinenum, "set::timesync", katsklaw@shell2:~/Unreal3.2.orig$ We do at least look for both timesync and timesynch, which is smart :) |
|
|
The default is fine, and I don't see any reason to put it in example.conf. Also, it is documented in unreal32docs.html Correct time is very important. Whether you run ntp or don't, in both cases with timesynch on it will work OK (unless of course, it cannot connect to the ntp server[s], but that's another issue...). |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-01-07 00:35 | katsklaw | New Issue | |
| 2011-01-07 04:16 | ohnobinki | Note Added: 0016583 | |
| 2011-01-08 00:07 | katsklaw | Note Added: 0016584 | |
| 2011-01-08 00:07 | katsklaw | Note Edited: 0016584 | |
| 2011-01-08 17:32 | syzop | Note Added: 0016585 | |
| 2011-01-08 17:32 | syzop | Status | new => closed |
| 2011-01-08 17:32 | syzop | Resolution | open => no change required |
