View Issue Details

IDProjectCategoryView StatusLast Update
0004108unrealircdpublic2012-05-07 12:10
ReportersyzopAssigned Tosyzop 
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Platformi686OSLinuxOS Version
Product Version3.2.9 
Target VersionFixed in Version3.2.10-rc1 
Summary0004108: crash on rehash or quit (after a while)
DescriptionFrom Dave (Nitrix):

IRCd crashes after a while, when it's rehashed.

This is the devel version of March 30 / April 1st: rev 5021 / 00e9422c700d
TagsNo tags attached.
3rd party modulesnetadmins, m_ircops, textban

Relationships

related to 0004109 closed valgrind: bogus warnings, or real issues? 

Activities

syzop

2012-05-07 11:20

administrator  

valgrind.log (138,708 bytes)

syzop

2012-05-07 11:27

administrator   ~0016989

(1st) valgrind log attached, lot of errors, but didn't actually crash yet.

syzop

2012-05-07 11:35

administrator   ~0016990

cannot reproduce the errors (or crash) with almost the same config on my own machine

syzop

2012-05-07 11:48

administrator   ~0016991

ah, it's when the user quits. I can reproduce this on my own machine now :)

==00:00:00:14.673 23126== Jump to the invalid address stated on the next line
==00:00:00:14.673 23126== at 0x4C15A0D: ???
==00:00:00:14.673 23126== by 0x9DAB2B1: m_quit (m_quit.c:170)
==00:00:00:14.673 23126== by 0x80734EF: parse (parse.c:451)
==00:00:00:14.673 23126== by 0x8071BE0: dopacket (packet.c:138)
==00:00:00:14.673 23126== by 0x805C8CC: read_packet (s_bsd.c:1625)
==00:00:00:14.673 23126== by 0x805D77B: read_message (s_bsd.c:2142)
==00:00:00:14.673 23126== by 0x806BFD7: main (ircd.c:1864)
==00:00:00:14.673 23126== Address 0x4c15a0d is not stack'd, malloc'd or (recently) free'd

#0 0x04c15a0d in ?? ()
#1 0x09dab2b2 in m_quit (cptr=0x9670000, sptr=0x9670000, parc=2, parv=0x81496c0) at m_quit.c:170
#2 0x080734f0 in parse (cptr=0x9670000, buffer=0x96700e4 "QUIT", bufend=0x96700ea "") at parse.c:451

#1 0x09dab2b2 in m_quit (cptr=0x9670000, sptr=0x9670000, parc=2, parv=0x81496c0) at m_quit.c:170
170 return exit_client(cptr, sptr, sptr, comment);

syzop

2012-05-07 12:10

administrator   ~0016992

Crash bug fixed in
http://hg.unrealircd.com/hg/unreal/rev/766727e05118
- Fixed another SASL crash bug. Always use HookAddEx, not HookAdd!
  Crash occured after the first quit of a user after a REHASH.
  Reported by Dave (0004108).


Please check out latest HG repository and see if this resolves your issue completely.

I've cloned this bug report to another issue, to investigate if the other valgrind warnings/errors are also a real issue or just bogus warnings.

Issue History

Date Modified Username Field Change
2012-05-07 11:19 syzop New Issue
2012-05-07 11:19 syzop Status new => assigned
2012-05-07 11:19 syzop Assigned To => syzop
2012-05-07 11:20 syzop File Added: valgrind.log
2012-05-07 11:21 syzop 3rd party modules => netadmins, m_ircops, textban
2012-05-07 11:22 syzop Description Updated View Revisions
2012-05-07 11:27 syzop Note Added: 0016989
2012-05-07 11:35 syzop Note Added: 0016990
2012-05-07 11:37 syzop Assigned To syzop =>
2012-05-07 11:37 syzop Status assigned => new
2012-05-07 11:48 syzop Note Added: 0016991
2012-05-07 11:48 syzop Summary crash on rehash (after a while) => crash on rehash or quit (after a while)
2012-05-07 12:09 syzop Issue cloned: 0004109
2012-05-07 12:09 syzop Relationship added related to 0004109
2012-05-07 12:09 syzop Reproducibility random => always
2012-05-07 12:09 syzop View Status private => public
2012-05-07 12:10 syzop Note Added: 0016992
2012-05-07 12:10 syzop Status new => resolved
2012-05-07 12:10 syzop Fixed in Version => 3.2.10-rc1
2012-05-07 12:10 syzop Resolution open => fixed
2012-05-07 12:10 syzop Assigned To => syzop