View Issue Details

IDProjectCategoryView StatusLast Update
0004161unrealircdpublic2013-01-14 10:32
Reporterlbalbalba Assigned Tonenolod 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.2.10 
Summary0004161: static src analysis (for fun and profit)
DescriptionHi,
 
 
Just for fun, I decided to run the llvm/clang static source code analyzer (see: http://clang-analyzer.llvm.org/) on UnrealIRCd. For those interested, the results can be found here :


http://lbalbalba.x90x.net/clang-analyzer/unrealircd/



Regards,
 
 
John Smith.
3rd party modules

Activities

Stealth

2013-01-12 21:00

reporter   ~0017350

Over the years I have learned that code checking utilities are not always that accurate. Efficient and functional code does not always mean the code is clean and readable by external code processors. There are also times where code may appear to be broken, but when the functions are called they are perfectly logical and entirely valid.

So because of all this, we need to determine if the "bugs" that are "detected" by code analysis are really bugs so simply false positives output due to the code being unexpectedly dynamic at a certain point.

I'm going to mark this as feedback, perhaps Syzop or nenolod can check out the analysis result and give some input or interpretation on what you're seeing.

nenolod

2013-01-13 06:18

reporter   ~0017351

This report doesn't really provide any new information. It identifies areas in the code which need to be refactored which we already knew about, and the assumptions it makes for the other bugs are impossible.

lbalbalba

2013-01-14 10:30

reporter   ~0017359

Well I guess that means that this issue can be closed. Thanks for taking the time to look at it, though.

nenolod

2013-01-14 10:32

reporter   ~0017360

Alright, I am going to close it out then.

Issue History

Date Modified Username Field Change
2013-01-12 15:54 lbalbalba New Issue
2013-01-12 21:00 Stealth Note Added: 0017350
2013-01-12 21:00 Stealth Status new => feedback
2013-01-13 06:18 nenolod Note Added: 0017351
2013-01-14 10:30 lbalbalba Note Added: 0017359
2013-01-14 10:32 nenolod Note Added: 0017360
2013-01-14 10:32 nenolod Status feedback => closed
2013-01-14 10:32 nenolod Assigned To => nenolod
2013-01-14 10:32 nenolod Resolution open => fixed